Fix triton_reshape to properly expand Min keyword in triton codegen
#137357
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137357
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2ce12ff with merge base 932b994 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
|
@pytorchbot label "topic: not user facing" |
arui-meta
force-pushed
the
export-D63850158
branch
from
da37a6d to
150f59c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
arui-meta
force-pushed
the
export-D63850158
branch
from
150f59c to
04f5710
Compare
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,mtia,inplace} //glow/fb/fx/fba/tests:test_fba_inductor -- -r test_Min_keyword_in_block_shape ``` Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
arui-meta
force-pushed
the
export-D63850158
branch
from
04f5710 to
f5aa40e
Compare
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
arui-meta
force-pushed
the
export-D63850158
branch
from
f5aa40e to
a9335b2
Compare
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Reviewed By: blaine-rister Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Reviewed By: blaine-rister Differential Revision: D63850158
arui-meta
force-pushed
the
export-D63850158
branch
from
a9335b2 to
2ce12ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
5 participants
Summary: Previously triton_reshape will generate code with
Minkeyword in it, which is incorrect. This diff updates the triton_reshape function to properly expandMinkeyword to<.Test Plan:
Differential Revision: D63850158
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang