fix specialization bug in unflatten + preserve_module_call_signature #137363
Conversation
avikchaudhuri
requested review from
angelayi,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137363
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f3c4861 with merge base c0deec1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63913750 |
|
This pull request was exported from Phabricator. Differential Revision: D63913750 |
avikchaudhuri
force-pushed
the
export-D63913750
branch
from
141e21d to
14a3b52
Compare
avikchaudhuri
force-pushed
the
export-D63913750
branch
from
14a3b52 to
280416d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63913750 |
…ytorch#137363) Summary: Pull Request resolved: pytorch#137363 In unflatten, when we generate module calls when their signature has been preserved, we do not pass the original constant args. This can cause strange effects, e.g., if the module is swapped out with itself, we may suddenly go down a different path than the original, or even crash. Test Plan: added a test Reviewed By: angelayi Differential Revision: D63913750
avikchaudhuri
force-pushed
the
export-D63913750
branch
from
280416d to
f3c4861
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63913750 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary: In unflatten, when we generate module calls when their signature has been preserved, we do not pass the original constant args. This can cause strange effects, e.g., if the module is swapped out with itself, we may suddenly go down a different path than the original, or even crash.
Test Plan: added a test
Reviewed By: angelayi
Differential Revision: D63913750