KEMBAR78
add meta for _segment_reduce_backward by bdhirsh · Pull Request #137442 · pytorch/pytorch · GitHub
Skip to content

Conversation

@bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Oct 7, 2024

reland of #124988

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137442

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9268bb5 with merge base f33ffd0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

bdhirsh added a commit that referenced this pull request Oct 7, 2024
ghstack-source-id: 0ce1b08
Pull Request resolved: #137442
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Oct 7, 2024

cc @ezyang if you don't mind stamping (originally from #124988, I can't reopen the PR anymore so I remade it)

@bdhirsh bdhirsh added the release notes: composability release notes category label Oct 7, 2024
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@bdhirsh bdhirsh requested a review from Chillee as a code owner October 8, 2024 14:34
bdhirsh added a commit that referenced this pull request Oct 8, 2024
ghstack-source-id: 260afea
Pull Request resolved: #137442
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Oct 8, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/bdhirsh/618/head branch November 8, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants