KEMBAR78
Document that load_inline requires having a compiler installed by janeyx99 · Pull Request #137521 · pytorch/pytorch · GitHub
Skip to content

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Oct 8, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137521

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e5bfb1f with merge base 2268319 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 requested review from albanD and zou3519 October 8, 2024 20:55
@janeyx99 janeyx99 added release notes: cpp release notes category topic: docs topic category labels Oct 8, 2024
@zou3519 zou3519 requested a review from malfet October 8, 2024 21:43
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but @malfet would know better if we can make this more precise

@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 8, 2024
janeyx99 added a commit that referenced this pull request Oct 8, 2024
Comment on lines 1635 to 1636
a CUDA extension, you will need to additionally install the corresponding CUDA nvcc
and any other dependencies your code has. Compiling toolchains are not included
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would name this "cuda toolkit (that contains nvcc and necessary headers in particular)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this cuda toolkit the same one available on conda? Cuz the forum q poster mentioned installing this and having it not be enough

@janeyx99 janeyx99 changed the title Document that additional toolchains need to be installed for load_inline Document that load_inline requires having a compiler installed Oct 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 8, 2024
@janeyx99 janeyx99 removed the Stale label Dec 8, 2024
janeyx99 added a commit that referenced this pull request Dec 10, 2024
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/janeyx99/187/head branch January 11, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cpp release notes category topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants