KEMBAR78

fix test_constant_output by avikchaudhuri · Pull Request #137547 · pytorch/pytorch · GitHub

fix test_constant_output #137547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

avikchaudhuri wants to merge 1 commit into pytorch:main from avikchaudhuri:export-D64081786

Contributor

avikchaudhuri commented Oct 9, 2024

Summary: Fixes a couple of problems: constants didn't have metadata before creating graph signatures, and graph signatures weren't updated when lifting constants.

Test Plan: fixed test

Differential Revision: D64081786

avikchaudhuri requested review from angelayi, tugsbayasgalan, ydwu4 and zhxchen17 as code owners

October 9, 2024 01:18

pytorch-bot bot commented Oct 9, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137547

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 09a178d with merge base 3610467 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor release notes: export labels

Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D64081786

facebook-github-bot added the fb-exported label

tugsbayasgalan reviewed

View reviewed changes

torch/export/_trace.py Outdated Show resolved Hide resolved

torch/export/_trace.py Outdated Show resolved Hide resolved

angelayi reviewed

View reviewed changes

torch/export/_trace.py Outdated Show resolved Hide resolved

torch/_export/passes/lift_constants_pass.py Outdated Show resolved Hide resolved

avikchaudhuri force-pushed the export-D64081786 branch from 56da78f to c222ffc Compare

October 10, 2024 00:41

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64081786

avikchaudhuri force-pushed the export-D64081786 branch from c222ffc to ea98931 Compare

October 10, 2024 00:44

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64081786

tugsbayasgalan approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

avikchaudhuri force-pushed the export-D64081786 branch from ea98931 to 3234945 Compare

October 10, 2024 01:12

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64081786


          fix test_constant_output (pytorch#137547)

09a178d

Summary:
Pull Request resolved: pytorch#137547

Fixes a couple of problems: constants didn't have metadata before creating graph signatures, and graph signatures weren't updated when lifting constants.

Test Plan: fixed test

Reviewed By: tugsbayasgalan

Differential Revision: D64081786

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64081786

avikchaudhuri force-pushed the export-D64081786 branch from 3234945 to 09a178d Compare

October 10, 2024 01:16

Contributor

facebook-github-bot commented Oct 10, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

Collaborator

pytorchmergebot commented Oct 10, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the merging label

pytorchmergebot added the Merged label

pytorchmergebot closed this in

365722f

pytorchmergebot removed the merging label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged release notes: export