KEMBAR78
Clarify opt-einsum usage, fix #127109 by janeyx99 · Pull Request #137596 · pytorch/pytorch · GitHub
Skip to content

Clarify opt-einsum usage, fix #127109 #137596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clarify opt-einsum usage, fix #127109 #137596

wants to merge 2 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Oct 9, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137596

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4122cf4 with merge base de4c2a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Oct 9, 2024
@janeyx99
Clarify opt- einsum usage, fix #127109
1203997 
ghstack-source-id: d7f9410
Pull Request resolved: #137596
@janeyx99
Copy link
Contributor Author

janeyx99 commented Oct 9, 2024

@bmillwood thoughts?

@janeyx99 janeyx99 added release notes: linalg_frontend release notes category topic: docs topic category labels Oct 9, 2024
@janeyx99 janeyx99 changed the title Clarify opt- einsum usage, fix #127109 Clarify opt-einsum usage, fix #127109 Oct 9, 2024
@janeyx99 janeyx99 linked an issue Oct 9, 2024 that may be closed by this pull request
torch.einsum docs don't mention that opt_einsum must be installed separately #127109
Closed
janeyx99 added a commit that referenced this pull request Oct 9, 2024
@janeyx99
Clarify opt- einsum usage, fix #127109
5e9a631 
ghstack-source-id: ff8b184
Pull Request resolved: #137596
albanD
albanD approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@janeyx99
Copy link
Contributor Author

janeyx99 commented Oct 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@bmillwood
Copy link

@bmillwood thoughts?

thanks, looks good :)

@github-actions github-actions bot deleted the gh/janeyx99/192/head branch November 9, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: linalg_frontend release notes category topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.einsum docs don't mention that opt_einsum must be installed separately

4 participants

@janeyx99 @pytorchmergebot @bmillwood @albanD