KEMBAR78
Remove numpy dependency for maia serialization by mikaylagawarecki · Pull Request #137600 · pytorch/pytorch · GitHub
Skip to content

Remove numpy dependency for maia serialization #137600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove numpy dependency for maia serialization #137600

wants to merge 4 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Oct 9, 2024 •
edited
Loading

@mikaylagawarecki mikaylagawarecki mentioned this pull request Oct 9, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137600

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2043f5c with merge base 09848c8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Oct 9, 2024
@mikaylagawarecki
Remove numpy dependency for maia serialization
0dae3aa 
ghstack-source-id: c3eae83
Pull Request resolved: #137600
@mikaylagawarecki mikaylagawarecki added release notes: python_frontend python frontend release notes category topic: not user facing topic category labels Oct 9, 2024
@mikaylagawarecki mikaylagawarecki mentioned this pull request Oct 9, 2024
Closed
@mikaylagawarecki mikaylagawarecki requested review from thiagocrepaldi and removed request for thiagocrepaldi October 9, 2024 16:31
@mikaylagawarecki
Update on "Remove numpy dependency for maia serialization"
df5bf22 
See rationale in #137444 description




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Oct 16, 2024
@mikaylagawarecki
Remove numpy dependency for maia serialization
918b118 
ghstack-source-id: d68581d
Pull Request resolved: #137600
@mikaylagawarecki
Update on "Remove numpy dependency for maia serialization"
ca72364 
See rationale in #137444 description




[ghstack-poisoned]
@mikaylagawarecki
Update on "Remove numpy dependency for maia serialization"
2043f5c 
See rationale in #137444 description




[ghstack-poisoned]
@mikaylagawarecki mikaylagawarecki mentioned this pull request Oct 25, 2024
Closed
albanD
albanD approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@mikaylagawarecki mikaylagawarecki mentioned this pull request Oct 28, 2024
Closed
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Oct 29, 2024
@mikaylagawarecki @rahulsingh-intel
Remove numpy dependency for maia serialization (pytorch#137600)
6dcf780 
See rationale in pytorch#137444 description

Pull Request resolved: pytorch#137600
Approved by: https://github.com/albanD
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@mikaylagawarecki @rahulsingh-intel
Remove numpy dependency for maia serialization (pytorch#137600)
b2b8ec9 
See rationale in pytorch#137444 description

Pull Request resolved: pytorch#137600
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/mikaylagawarecki/268/head branch November 28, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @pytorchmergebot @albanD