-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[MPS] Add tri[lu]_indices
#137648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPS] Add tri[lu]_indices
#137648
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137648
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3f27ffd with merge base de4c2a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
| @@ -1,20 +1,239 @@ | |||
| // Copyright © 2022 Apple Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, legal nit but @malfet this copyright comment is not correct given the CLA, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All copyright headers are superseded by top level license, unless it's a 3rd party code. But I don't want to fight this fight today...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
|
@pytorchbot merge -f "MPS + Lint tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
tri[lu]_indices#137648Tensor->TensorBasein OperationUtils.h #137647Requested in #77764 (comment)
Copy-n-paste kernel implementation from
pytorch/aten/src/ATen/native/cuda/TensorFactories.cu
Line 92 in 13cf836
though use
floatinstead ofdoublefor square root computation