KEMBAR78
[MPS] Add `tri[lu]_indices` by malfet · Pull Request #137648 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 9, 2024

Stack from ghstack (oldest at bottom):

Requested in #77764 (comment)
Copy-n-paste kernel implementation from

// To find the max integer that does not exceed the root of an int64_t variable,

though use float instead of double for square root computation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137648

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3f27ffd with merge base de4c2a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@malfet malfet marked this pull request as draft October 9, 2024 21:55
malfet added a commit that referenced this pull request Oct 9, 2024
ghstack-source-id: 7d3cfe8
Pull Request resolved: #137648
@malfet malfet marked this pull request as ready for review October 9, 2024 23:21
@malfet malfet requested a review from albanD October 9, 2024 23:21
@@ -1,20 +1,239 @@
// Copyright © 2022 Apple Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, legal nit but @malfet this copyright comment is not correct given the CLA, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All copyright headers are superseded by top level license, unless it's a 3rd party code. But I don't want to fight this fight today...

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@malfet
Copy link
Contributor Author

malfet commented Oct 10, 2024

@pytorchbot merge -f "MPS + Lint tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/34/head branch November 10, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants