KEMBAR78
Pass all arguments when quantizing embedding bag from float by annop-w · Pull Request #137697 · pytorch/pytorch · GitHub
Skip to content

Conversation

@annop-w
Copy link
Contributor

@annop-w annop-w commented Oct 10, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137697

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 55a7d9f with merge base 4dd04db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@annop-w
Copy link
Contributor Author

annop-w commented Oct 10, 2024

@pytorchbot label "module: arm"

@annop-w
Copy link
Contributor Author

annop-w commented Oct 10, 2024

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Oct 10, 2024
@ezyang ezyang requested review from jerryzh168 and vkuzo October 11, 2024 01:21
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 11, 2024
@annop-w
Copy link
Contributor Author

annop-w commented Oct 21, 2024

@malfet Could I please get a review ? Thank you.

@malfet malfet added the ciflow/linux-aarch64 linux aarch64 CI workflow label Oct 24, 2024
@ZainRizvi
Copy link
Contributor

hi, can you please rebase this PR to the latest viable/strict branch? This one is pulling in some old code that is stopping you from getting a clean CI run

@ZainRizvi
Copy link
Contributor

(commenting here with just @pytorchmergebot rebase will do it for you)

@annop-w
Copy link
Contributor Author

annop-w commented Oct 28, 2024

@pytorchmergebot rebase

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2024

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

@aditew01
Copy link
Collaborator

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased qembedding onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout qembedding && git pull --rebase)

@snadampal
Copy link
Collaborator

Hi @annop-w , please fix the linter failure.

 Warning (PYFMT) format
    Run `lintrunner -a` to apply this patch.

    You can run `lintrunner -a` to apply this patch.

    383  383 | 
    384  384 |         # Create quantized EmbeddingBag module and pass in the quantized weight
    385  385 |         qembedding_bag = EmbeddingBag(
    385      |-            mod.num_embeddings,mod.embedding_dim,max_norm=mod.max_norm,norm_type=mod.norm_type,
    386      |-            scale_grad_by_freq=mod.scale_grad_by_freq,mode=mod.mode,sparse=mod.sparse,
    387      |-            include_last_offset=mod.include_last_offset, dtype=dtype
         386 |+            mod.num_embeddings,
         387 |+mod.embedding_dim,
         388 |+max_norm=mod.max_norm,
         389 |+norm_type=mod.norm_type,
         390 |+            scale_grad_by_freq=mod.scale_grad_by_freq,
         391 |+mode=mod.mode,
         392 |+sparse=mod.sparse,
         393 |+            include_last_offset=mod.include_last_offset,
         394 |+            dtype=dtype,
    389  395 |         )
    390  396 |         qembedding_bag.set_weight(qweight)
    391  397 |         return qembedding_bag

@annop-w
Copy link
Contributor Author

annop-w commented Oct 28, 2024

@snadampal Done.

@snadampal snadampal self-requested a review November 1, 2024 14:44
@annop-w
Copy link
Contributor Author

annop-w commented Nov 6, 2024

@malfet @digantdesai Could this now be merged ? Thank you.

@annop-w
Copy link
Contributor Author

annop-w commented Nov 6, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@annop-w
Copy link
Contributor Author

annop-w commented Nov 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@annop-w annop-w deleted the qembedding branch March 19, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 open source release notes: AO frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants