KEMBAR78

fix test_lazy_module_kwargs by avikchaudhuri · Pull Request #137705 · pytorch/pytorch · GitHub

fix test_lazy_module_kwargs #137705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

avikchaudhuri wants to merge 1 commit into pytorch:main from avikchaudhuri:export-D64185644

Contributor

avikchaudhuri commented Oct 10, 2024

Test Plan: fixed

Differential Revision: D64185644

pytorch-bot bot commented Oct 10, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137705

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 80ac69e with merge base 93bbc8a ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.g4dn.12xlarge.nvidia.gpu) (gh) (similar failure)
distributed/test_inductor_collectives.py::TestCollectivesMultiProc::test_allreduce_inductor_cudagraph_trees
trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh) (similar failure)
distributed/test_inductor_collectives.py::TestCollectivesMultiProc::test_allreduce_inductor_cudagraph_trees

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.g4dn.12xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/_tools/test_runtime_estimator.py::TestRuntimeEstimator::test_transformer_runtime

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor release notes: AO frontend labels

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64185644

facebook-github-bot added the fb-exported label

avikchaudhuri force-pushed the export-D64185644 branch from 7ce7e9e to 880e323 Compare

October 10, 2024 17:14

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64185644

tugsbayasgalan approved these changes

View reviewed changes

torch/_functorch/aot_autograd.py Outdated

Contributor

tugsbayasgalan Oct 10, 2024

Are they previously special handled in dynamo?

Contributor Author

avikchaudhuri Oct 10, 2024

This only applies to non-strict, since this bug was in detecting arribute assigments (in general Dynamo errors so we don't run this detection there).

pytorch-bot bot added the ciflow/trunk label

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64185644

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          fix test_lazy_module_kwargs (pytorch#137705)

ab4c86a

Summary: Pull Request resolved: pytorch#137705

Test Plan: fixed

Differential Revision: D64185644

avikchaudhuri force-pushed the export-D64185644 branch from 880e323 to ab4c86a Compare

October 10, 2024 17:17

avikchaudhuri added a commit to avikchaudhuri/pytorch that referenced this pull request


          fix test_lazy_module_kwargs (pytorch#137705)

0ea1b80

Summary: Pull Request resolved: pytorch#137705

Test Plan: fixed

Reviewed By: tugsbayasgalan

Differential Revision: D64185644

avikchaudhuri force-pushed the export-D64185644 branch from ab4c86a to 0ea1b80 Compare

October 10, 2024 21:22

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64185644


          fix test_lazy_module_kwargs (pytorch#137705)

80ac69e

Summary: Pull Request resolved: pytorch#137705

Test Plan: fixed

Reviewed By: tugsbayasgalan

Differential Revision: D64185644

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64185644

avikchaudhuri force-pushed the export-D64185644 branch from 0ea1b80 to 80ac69e Compare

October 10, 2024 21:26

Contributor

facebook-github-bot commented Oct 11, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Oct 11, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

8262f6d

pytorchmergebot removed the merging label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged release notes: AO frontend