-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[DeviceMesh] Fixed from_group when passing tensor mesh
#137713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137713
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 58e7c71 with merge base d1b87e2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| ) or (mesh is not None and mesh != group_ranks): | ||
| ) or ( | ||
| mesh is not None | ||
| and not isinstance(mesh, torch.Tensor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: periodic / parallelnative-linux-jammy-py3.9-gcc11 / test (default, 1, 3, linux.2xlarge) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "unrelated default periodic test failing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #137721 Approved by: https://github.com/kwen2501 ghstack dependencies: #137713
…137792) This fixes #137577. Pull Request resolved: #137792 Approved by: https://github.com/fegin, https://github.com/H-Huang ghstack dependencies: #137713, #137721
Stack from ghstack (oldest at bottom):
from_groupwhen passing tensormesh#137713This fixes #137676. (sorry for messing this up in the original PR 😓 )
cc @XilunWu @H-Huang @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o