KEMBAR78

fix test_retrace_pre_autograd by avikchaudhuri · Pull Request #137733 · pytorch/pytorch · GitHub

fix test_retrace_pre_autograd #137733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

avikchaudhuri wants to merge 1 commit into pytorch:main from avikchaudhuri:export-D64200918

Contributor

avikchaudhuri commented Oct 10, 2024

Test Plan: fixed

Differential Revision: D64200918

avikchaudhuri requested review from angelayi, tugsbayasgalan, ydwu4 and zhxchen17 as code owners

October 10, 2024 21:14

pytorch-bot bot commented Oct 10, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137733

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit b48555a with merge base 573101a ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh) (similar failure)
distributed/test_inductor_collectives.py::TestCollectivesMultiProc::test_allreduce_inductor_cudagraph_trees
trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 1, 3, linux.g4dn.12xlarge.nvidia.gpu) (gh) (similar failure)
distributed/test_inductor_collectives.py::TestCollectivesMultiProc::test_allreduce_inductor_cudagraph_trees

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh) (trunk failure)
distributed/_tools/test_runtime_estimator.py::TestRuntimeEstimator::test_transformer_runtime

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: export label

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

facebook-github-bot added the fb-exported label

avikchaudhuri force-pushed the export-D64200918 branch from 7c75489 to f95bbab Compare

October 10, 2024 21:25

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

pianpwk approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

tugsbayasgalan approved these changes

View reviewed changes

avikchaudhuri force-pushed the export-D64200918 branch from f95bbab to 5dc752b Compare

October 10, 2024 21:34

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

avikchaudhuri force-pushed the export-D64200918 branch from 5dc752b to ae42e10 Compare

October 10, 2024 22:41

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

avikchaudhuri force-pushed the export-D64200918 branch from ae42e10 to 8583b4a Compare

October 10, 2024 22:45

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

avikchaudhuri force-pushed the export-D64200918 branch from 8583b4a to 62fd925 Compare

October 10, 2024 23:19

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918


          fix test_retrace_pre_autograd (pytorch#137733)

b48555a

Summary: Pull Request resolved: pytorch#137733

Test Plan: fixed

Reviewed By: tugsbayasgalan, pianpwk

Differential Revision: D64200918

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D64200918

avikchaudhuri force-pushed the export-D64200918 branch from 62fd925 to b48555a Compare

October 10, 2024 23:22

Contributor

facebook-github-bot commented Oct 11, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

Collaborator

pytorchmergebot commented Oct 11, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the merging label

pytorchmergebot closed this in

8ee361e

pytorchmergebot added Merged and removed merging labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tugsbayasgalan tugsbayasgalan approved these changes

pianpwk pianpwk approved these changes

zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

angelayi Awaiting requested review from angelayi angelayi is a code owner

Labels

ciflow/trunk fb-exported Merged release notes: export