Fix try_solve for s1*s2 == 0 when both symbols are unknown #137919
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137919
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6d945b4 with merge base f568d48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
| if not (isinstance(e, INEQUALITY_TYPES) and other.is_negative is None): | ||
| # We also divide only when we know 'rhs' is not zero. | ||
| if not (isinstance(e, INEQUALITY_TYPES) and other.is_negative is None) and not ( | ||
| not isinstance(e, INEQUALITY_TYPES) and rhs.is_zero |
There was a problem hiding this comment.
Should we instead avoid this if we do not definitely know that rhs is NOT zero? Similar to how the is_negative test is an is None test.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec