KEMBAR78
Enable Python-3.13 builds on MacOS by malfet · Pull Request #138037 · pytorch/pytorch · GitHub
Skip to content

Enable Python-3.13 builds on MacOS #138037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Enable Python-3.13 builds on MacOS #138037

wants to merge 3 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 15, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

All logic changes happen in builder repo, namely:

@malfet
Update
ce4f3bf 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner October 15, 2024 23:44
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138037

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit b98fdc5 with merge base cef6c3d (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 15, 2024
@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Oct 16, 2024
@malfet
Update
d40fcc7 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Oct 16, 2024
Closed
huydhn
huydhn approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pending CI to finish

@malfet
Update
b98fdc5 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Oct 16, 2024
@malfet
Enable Python-3.13 builds on MacOS
363b6f3 
ghstack-source-id: af59768
Pull Request resolved: #138037
@malfet
Copy link
Contributor Author

malfet commented Oct 16, 2024

@pytorchbot merge -f "Lint and MacOS binary builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Oct 16, 2024
Closed
37 tasks
@github-actions github-actions bot deleted the gh/malfet/40/head branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @huydhn