KEMBAR78
Use default context on Windows for Intel GPU by guangyey · Pull Request #138049 · pytorch/pytorch · GitHub
Skip to content

Use default context on Windows for Intel GPU #138049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Use default context on Windows for Intel GPU #138049

wants to merge 12 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 16, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Motivation

Use default context in Windows to keep consistency with Linux. It makes it easy to interact with external libraries like dlpack.

Additional Context

This PR depends on Intel GPU oneAPI 2025.0.

cc @gujinghui @EikanWang @fengyuan14

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138049

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3972cf1 with merge base 9e299b8 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey added a commit that referenced this pull request Oct 16, 2024
@guangyey
Use default context in Windows for Intel GPU
e72090e 
ghstack-source-id: 8efdb32
Pull Request resolved: #138049
@guangyey guangyey added module: xpu Intel XPU related issues release notes: xpu release notes category labels Oct 16, 2024
@guangyey guangyey changed the title Use default context in Windows for Intel GPU [WIP] Use default context in Windows for Intel GPU Oct 16, 2024
@guangyey guangyey marked this pull request as draft October 16, 2024 02:27
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label Oct 16, 2024
@guangyey
Update
5cdec95 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 12, 2024
@guangyey
Use default context in Windows for Intel GPU
ffd7fd7 
ghstack-source-id: f6fe9ad
Pull Request resolved: #138049
@guangyey guangyey changed the title [WIP] Use default context in Windows for Intel GPU Use default context in Windows for Intel GPU Nov 12, 2024
@guangyey guangyey marked this pull request as ready for review November 12, 2024 02:35
@guangyey guangyey added this to the 2.6.0 milestone Nov 12, 2024
guangyey added a commit that referenced this pull request Nov 12, 2024
@guangyey
Use default context in Windows for Intel GPU
08a9cae 
ghstack-source-id: 71066c2
Pull Request resolved: #138049
@guangyey guangyey changed the title Use default context in Windows for Intel GPU Use default context on Windows for Intel GPU Nov 12, 2024
@guangyey
Update
c437360 
[ghstack-poisoned]
@guangyey
Update
43706d2 
[ghstack-poisoned]
@guangyey
Update
f93c6c8 
[ghstack-poisoned]
@guangyey
Update
1b7585d 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@guangyey
Update
ec734ff 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/77/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138049)

pytorchmergebot pushed a commit that referenced this pull request Nov 18, 2024
@guangyey
Use default context in Windows for Intel GPU
5cb0c43 
ghstack-source-id: 37f1f0c
Pull Request resolved: #138049
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Update
05dd0f6 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/77/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138049)

@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Update
dcd1db1 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/77/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138049)

pytorchmergebot pushed a commit that referenced this pull request Nov 25, 2024
@guangyey
Use default context in Windows for Intel GPU
0776692 
ghstack-source-id: ba9a612
Pull Request resolved: #138049
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 25, 2024
@guangyey
Copy link
Collaborator Author

These failures are related to #141466, and we have filed a PR #141470 to fix it.

@guangyey
Copy link
Collaborator Author

@gujinghui @EikanWang I was wondering if you could help review this PR?

@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Update
3972cf1 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/77/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138049)

pytorchmergebot pushed a commit that referenced this pull request Nov 27, 2024
@guangyey
Use default context in Windows for Intel GPU
7a996e8 
ghstack-source-id: f0f3c63
Pull Request resolved: #138049
@guangyey
Copy link
Collaborator Author

@gujinghui @EikanWang This PR will impact the PyTorch XPU window build. We have tested locally; no regression UTs occurred. May I know if it is reasonable to land it?

@guangyey
Copy link
Collaborator Author

"Unrelated failure, there is an issue to track it #141705"
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: xpu / linux-jammy-xpu-2025_0-py3.9 / test (default, 1, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@guangyey
Use default context on Windows for Intel GPU (pytorch#138049)
76e7f5d 
# Motivation
Use default context in Windows to keep consistency with Linux. It makes it easy to interact with external libraries like `dlpack`.

# Additional Context
This PR depends on Intel GPU oneAPI 2025.0.

Pull Request resolved: pytorch#138049
Approved by: https://github.com/gujinghui
@github-actions github-actions bot deleted the gh/guangyey/77/head branch December 30, 2024 02:07
@atalman atalman mentioned this pull request Jan 13, 2025
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gujinghui gujinghui gujinghui approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source release notes: xpu release notes category

Projects

PyTorch Intel
Status: Done

Milestone

2.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @pytorchmergebot @gujinghui @pytorchbot