KEMBAR78
[c10d][ez] Add more inline comments to CUDAEventCache code by fduwjj · Pull Request #138079 · pytorch/pytorch · GitHub
Skip to content

[c10d][ez] Add more inline comments to CUDAEventCache code #138079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[c10d][ez] Add more inline comments to CUDAEventCache code #138079

wants to merge 1 commit into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Oct 16, 2024 •
edited
Loading

@fduwjj fduwjj mentioned this pull request Oct 16, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138079

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 8cb3b83 with merge base a77bb85 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 16, 2024
fduwjj added a commit that referenced this pull request Oct 16, 2024
@fduwjj
[c10d] Add more inline comments to CUDAEventCache code
ba1a11a 
ghstack-source-id: 0c2c5af
Pull Request resolved: #138079
@fduwjj fduwjj requested a review from kwen2501 October 16, 2024 15:48
@fduwjj fduwjj changed the title [c10d] Add more inline comments to CUDAEventCache code [c10d][ez] Add more inline comments to CUDAEventCache code Oct 16, 2024
@fduwjj fduwjj requested a review from wconstab October 16, 2024 15:49
@fduwjj fduwjj added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2024
kwen2501
kwen2501 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fduwjj
Copy link
Contributor Author

fduwjj commented Oct 16, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/fduwjj/149/head branch November 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fduwjj @pytorchmergebot @kwen2501