Add architecture to XPU device property #138186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138186
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1976202 with merge base 565a794 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
changed the title
guangyey
added
ciflow/xpu
guangyey
changed the title
ezyang
approved these changes
Nov 13, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation Add `architecture` to XPU device property. In some cases, low-level application code can use special features or do specific optimizations depending on the device architecture, and this PR enables such applications. Modified from https://github.com/pytorch/pytorch/pull/129675/files Pull Request resolved: pytorch#138186 Approved by: https://github.com/ezyang
whitneywhtsang
added a commit
to intel/intel-xpu-backend-for-triton
that referenced
this pull request
Dec 12, 2024
With pytorch/pytorch#138186, `architecture` is added to XPU device property. Instead of hard coding `pvc` when invoking `ocloc`, this PR changed to dynamically passing the device architecture parsed. --------- Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
Add
architectureto XPU device property.In some cases, low-level application code can use special features or do specific optimizations depending on the device architecture, and this PR enables such applications.
Modified from https://github.com/pytorch/pytorch/pull/129675/files
cc @gujinghui @EikanWang @fengyuan14