KEMBAR78
Add environment variable to force no weights_only load by mikaylagawarecki · Pull Request #138225 · pytorch/pytorch · GitHub
Skip to content

Add environment variable to force no weights_only load #138225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Add environment variable to force no weights_only load #138225

wants to merge 9 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Oct 17, 2024 •
edited
Loading

In preparation for weights_only flip, if users don't have access to the torch.load call

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138225

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9620245 with merge base 7ec21a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki added release notes: python_frontend python frontend release notes category topic: improvements topic category labels Oct 17, 2024
@mikaylagawarecki
Update on "Add environment variable to force no weights_only load"
2e2ec1a 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call




[ghstack-poisoned]
@mikaylagawarecki
Update on "Add environment variable to force no weights_only load"
f750688 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Oct 17, 2024
@mikaylagawarecki
Add environment variable to force no weights_only load
d5d7fa2 
ghstack-source-id: 5e4009f
Pull Request resolved: #138225
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review October 17, 2024 20:58
albanD
albanD reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@mikaylagawarecki
Update on "Add environment variable to force no weights_only load"
bcdac73 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Oct 18, 2024
@mikaylagawarecki
Add environment variable to force no weights_only load
8384985 
ghstack-source-id: 952a96f
Pull Request resolved: #138225
albanD
albanD approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@mikaylagawarecki
Update on "Add environment variable to force no weights_only load"
b1a9b6d 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Oct 18, 2024
@mikaylagawarecki
Add environment variable to force no weights_only load
e52dc6d 
ghstack-source-id: 1718045
Pull Request resolved: #138225
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@mikaylagawarecki
Update
4e7cc10 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/275/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138225)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Update on "Add environment variable to force no weights_only load"
163a0a3 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Oct 18, 2024
@mikaylagawarecki
Add environment variable to force no weights_only load
8b10b00 
ghstack-source-id: b9ecd1a
Pull Request resolved: #138225
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@mikaylagawarecki
Update
9620245 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/275/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138225)

pytorchmergebot pushed a commit that referenced this pull request Oct 21, 2024
@mikaylagawarecki
Add environment variable to force no weights_only load
01b1157 
ghstack-source-id: 0ca6dc4
Pull Request resolved: #138225
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@mikaylagawarecki @SamGinzburg
Add environment variable to force no weights_only load (#138225)
d8e5d7d 
In preparation for `weights_only` flip, if users don't have access to the `torch.load` call

Pull Request resolved: #138225
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the gh/mikaylagawarecki/275/head branch November 21, 2024 02:09
@Archana-Shinde1 Archana-Shinde1 mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @pytorchmergebot @albanD