KEMBAR78
Small fix to Python rendering in documentation. by tfogal · Pull Request #138281 · pytorch/pytorch · GitHub
Skip to content

Conversation

@tfogal
Copy link
Contributor

@tfogal tfogal commented Oct 17, 2024

The text was being rendered as normal text but I believe was meant to be code.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138281

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c34bdf7 with merge base ee42a99 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tfogal / name: Tom Fogal (c34bdf7)

@tfogal
Copy link
Contributor Author

tfogal commented Oct 17, 2024

@pytorchbot label "release notes: documentation"

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2024

Didn't find following labels among repository labels: release notes: documentation

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 18, 2024
@tfogal tfogal force-pushed the tfogal/minor-fix-python-doc-rendering branch from dea2390 to 8ded322 Compare October 18, 2024 20:21
@tinglvv tinglvv added topic: not user facing topic category topic: docs topic category labels Oct 18, 2024
@janeyx99 janeyx99 added release notes: composability release notes category and removed topic: not user facing topic category labels Oct 24, 2024
@tfogal
Copy link
Contributor Author

tfogal commented Nov 5, 2024

@pytorchbot rebase

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

@tfogal
Copy link
Contributor Author

tfogal commented Nov 5, 2024

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

Could I request someone rebase or otherwise kick CI to run again? The actual error seems to have been:

2024-10-24T21:16:35.3866123Z + python -mpip install --pre numpy==2.0.0rc1
2024-10-24T21:16:36.0104162Z �[31mERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11�[0m�[31m
2024-10-24T21:16:36.0110458Z �[0m�[31mERROR: Could not find a version that satisfies the requirement numpy==2.0.0rc1 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0, 1.21.1, 1.22.0, 1.22.1, 1.22.2, 1.22.3, 1.22.4, 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, 1.23.5, 1.24.0, 1.24.1, 1.24.2, 1.24.3, 1.24.4, 1.25.0, 1.25.1, 1.25.2, 1.26.0, 1.26.1, 1.26.2, 1.26.3, 1.26.4, 2.0.0, 2.0.1, 2.0.2, 2.1.0rc1, 2.1.0, 2.1.1, 2.1.2)�[0m�[31m

and numpy is unrelated to this patch.

@janeyx99
Copy link
Contributor

janeyx99 commented Nov 5, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased tfogal/minor-fix-python-doc-rendering onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout tfogal/minor-fix-python-doc-rendering && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the tfogal/minor-fix-python-doc-rendering branch from 8ded322 to c34bdf7 Compare November 5, 2024 22:37
@janeyx99
Copy link
Contributor

janeyx99 commented Nov 7, 2024

image lgtm

@janeyx99
Copy link
Contributor

janeyx99 commented Nov 7, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@tfogal
Copy link
Contributor Author

tfogal commented Nov 15, 2024

@pytorchbot merge

Thanks for your help, Jane!

@tfogal tfogal deleted the tfogal/minor-fix-python-doc-rendering branch November 15, 2024 22:39
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
The text was being rendered as normal text but I believe was meant to be code.

Pull Request resolved: pytorch#138281
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: composability release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants