Add missing operator and corresponding unittest #138309
Conversation
cz2h
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138309
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20c7365 with merge base 29eb65f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added
the
triaged
|
I am deferring to export team on this |
This comment was marked as spam.
This comment was marked as spam.
|
@pytorchbot merge -i "unrelated problem" |
|
❌ 🤖 pytorchbot command failed: Try |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Comment with id 2440228348 not found Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build Details for Dev Infra teamRaised by workflow job |
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu), linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -i |
|
|
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
fix-serialize-missing-operator
branch
from
8f47163 to
6b8a376
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
Hi @ezyang , thanks for triggering the merge. For my own knowledge purpose, was the merge CI private and only accessible by meta employees or its an opensource project like pytorch? |
|
No, you can view it in Dr. CI hud here. Looks like a test failed though |
|
although it's a singleton error, it feels unrelated. let's try again |
|
@pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
fix-serialize-missing-operator
branch
from
6b8a376 to
20c7365
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#129690 Add operator.neg and oepartor.pos into _SYM_BOOL_OPS. Provide simple unit test under export/test_serialize.py that can reproduce the issue. Pull Request resolved: pytorch#138309 Approved by: https://github.com/ezyang, https://github.com/angelayi
6 participants
Fixes #129690
Add operator.neg and oepartor.pos into _SYM_BOOL_OPS.
Provide simple unit test under export/test_serialize.py that can reproduce the issue.