KEMBAR78
`addmm`: error on output dtype mismatch. by ysiraichi · Pull Request #138520 · pytorch/pytorch · GitHub
Skip to content

Conversation

@ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Oct 21, 2024

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138520

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 681f6bf with merge base 4dd04db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ysiraichi added a commit that referenced this pull request Oct 21, 2024
ghstack-source-id: abfc677
Pull Request resolved: #138520
@ysiraichi ysiraichi added the topic: not user facing topic category label Oct 21, 2024
@ysiraichi ysiraichi marked this pull request as draft October 23, 2024 19:37
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Oct 23, 2024
ghstack-source-id: 45a2a2b
Pull Request resolved: #138520
@ysiraichi
Copy link
Collaborator Author

ysiraichi commented Oct 23, 2024

Moved this PR to draft due to the CI failure. Can't reproduce it... It seems that abs is not raising errors when using meta device (even though I'm not modifying it)

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Oct 24, 2024
ghstack-source-id: cb48b8d
Pull Request resolved: #138520
[ghstack-poisoned]
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Oct 26, 2024
ghstack-source-id: 0307a50
Pull Request resolved: #138520
@ysiraichi ysiraichi marked this pull request as ready for review October 28, 2024 16:29
@ysiraichi
Copy link
Collaborator Author

This CI failure is a bit cryptic to me. Should I just update the expected compiling instruction count?

@ysiraichi ysiraichi requested a review from ezyang October 28, 2024 16:31
[ghstack-poisoned]
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Oct 28, 2024
ghstack-source-id: 26d2e5e
Pull Request resolved: #138520
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Oct 29, 2024
ghstack-source-id: 786b3a3
Pull Request resolved: #138520
@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@github-actions github-actions bot deleted the gh/ysiraichi/64/head branch November 30, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants