[PyTorch] Fix inductor bug with unrolled vectorized prod #138542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138542
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7eeef66 with merge base fb0da32 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64734116 |
swolchok
added a commit
that referenced
this pull request
Oct 22, 2024
This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) ghstack-source-id: 249268781 Pull Request resolved: #138542
|
Thanks for the reproducer! I will try to fix it. |
…zed prod" This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
…zed prod" This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
pytorch-bot
bot
added
the
module: cpu
leslie-fang-intel
added a commit
that referenced
this pull request
Oct 22, 2024
This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) ghstack-source-id: 70dddf6 Pull Request resolved: #138542
leslie-fang-intel
added a commit
that referenced
this pull request
Oct 22, 2024
This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) ghstack-source-id: 0b14666 Pull Request resolved: #138542
|
It seems passed the CI now with the fix. cc @jgong5 to take a further look of this fix. |
jgong5
approved these changes
Oct 22, 2024
|
cool, I wasn't sure this was the right way to fix it but it sure is simple! |
…zed prod" This issue is one of two inductor bugs blocking land of #137426. I don't have a fix yet, but this repros the C++ compile failure. Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64734116 |
This was referenced Oct 22, 2024
Closed
This was referenced Oct 22, 2024
swolchok
changed the title
This issue is one of two inductor bugs blocking land of #137426. Turned out to be simple Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64734116 |
swolchok
added a commit
that referenced
this pull request
Oct 22, 2024
Pull Request resolved: #138542 This issue is one of two inductor bugs blocking land of #137426. Turned out to be simple. ghstack-source-id: 249394951 Differential Revision: [D64734116](https://our.internmc.facebook.com/intern/diff/D64734116/)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
This was referenced Oct 22, 2024
malfet
approved these changes
Oct 24, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 24, 2024
These are ternary ops, not binary ops. Differential Revision: [D64794253](https://our.internmc.facebook.com/intern/diff/D64794253/) Pull Request resolved: #138655 Approved by: https://github.com/jgong5, https://github.com/malfet ghstack dependencies: #138486, #138542
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 24, 2024
The size of the destination array was too small. Differential Revision: [D64843491](https://our.internmc.facebook.com/intern/diff/D64843491/) Pull Request resolved: #138716 Approved by: https://github.com/jgong5, https://github.com/malfet ghstack dependencies: #138486, #138542, #138655
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 24, 2024
There is no guarantee that `len` here is enough for a full vector. This was causing at least one test failure on #137426. Differential Revision: [D64857786](https://our.internmc.facebook.com/intern/diff/D64857786/) Pull Request resolved: #138744 Approved by: https://github.com/jgong5, https://github.com/malfet ghstack dependencies: #138486, #138542, #138655, #138716
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 26, 2024
The correct vector length for ARM64 is 128 bits (16 bytes). We were previously using double this, apparently just because that would be the same length as AVX2. Differential Revision: [D63984039](https://our.internmc.facebook.com/intern/diff/D63984039/) Pull Request resolved: #137426 Approved by: https://github.com/jgong5, https://github.com/malfet ghstack dependencies: #138486, #138542, #138655, #138716, #138744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This issue is one of two inductor bugs blocking land of #137426. Turned out to be simple
Differential Revision: D64734116
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov