[pt2, docs] Add new PT2 troubleshooting doc #138620

williamwen42 · 2024-10-22T17:53:21Z

Stack from ghstack (oldest at bottom):

-> [pt2, docs] Add new PT2 troubleshooting doc #138620

[ghstack-poisoned]

pytorch-bot · 2024-10-22T17:53:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138620

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6cb4509 with merge base 91d38a5 ():

NEW FAILURE - The following job has failed:

Lint / pr-sanity-checks (gh)
##[error]Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 2bb7ff2 Pull Request resolved: #138620

[ghstack-poisoned]

docs/source/torch.compiler.rst

docs/source/torch.compiler_custom_backends.rst

docs/source/torch.compiler_troubleshooting_old.rst

ezyang · 2024-10-22T21:01:52Z

docs/source/torch.compiler_troubleshooting.rst

-PyTorch 2.0 Troubleshooting
-===========================
+``torch.compile`` Troubleshooting
+=================================


So what's the plan for keeping this up to date with changes in gdoc

This will become the source of truth - the troubleshooting gdoc is just a draft.

[ghstack-poisoned]

svekars

An editorial pass.

docs/source/torch.compiler_troubleshooting.rst

[ghstack-poisoned]

ghstack-source-id: 4028b0a Pull Request resolved: #138620

[ghstack-poisoned]

ghstack-source-id: 047bce8 Pull Request resolved: #138620

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

williamwen42 · 2024-10-25T17:35:28Z

@pytorchbot rebase

[ghstack-poisoned]

ghstack-source-id: df43264 Pull Request resolved: #138620

docs/source/torch.compiler_troubleshooting.rst

[ghstack-poisoned]

ghstack-source-id: df45b5f Pull Request resolved: #138620

[ghstack-poisoned]

ghstack-source-id: 1091815 Pull Request resolved: #138620

williamwen42 · 2024-11-07T18:53:32Z

Are we good to merge this?

williamwen42 · 2024-11-08T18:33:32Z

@pytorchbot merge

pytorchmergebot · 2024-11-08T18:35:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-11-08T18:35:36Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / pr-sanity-checks

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

williamwen42 · 2024-11-09T01:16:00Z

@pytorchbot merge -f "PR length is acceptable since change is doc related"

pytorchmergebot · 2024-11-09T01:17:28Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: pytorch#138620 Approved by: https://github.com/ezyang Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

yushangdi · 2025-01-29T16:38:49Z

docs/source/torch.compiler_troubleshooting.rst

+and have already been addressed, leaving more complex issues that do not reproduce easily.
+However, it is straightforward to attempt using the minifier, so it is worth trying even if it may not succeed.
+
+Instructions for operating the minifier can be found `here <https://pytorch.org/docs/stable/torch.compiler_troubleshooting_old.html>`__.


@williamwen42 This link seem to be dead. 404 in https://pytorch.org/docs/stable/torch.compiler_troubleshooting_old.html. Maybe we could update it?

Try again? The link looks active to me (also on icognito).

Try again? The link looks active to me (also on icognito).

oh, works now! Not sure what happened when I tried it earlier

[pt2, docs] Add new PT2 troubleshooting doc

22e223d

[ghstack-poisoned]

williamwen42 requested a review from a team as a code owner October 22, 2024 17:53

pytorch-bot bot added the release notes: releng release notes category label Oct 22, 2024

williamwen42 requested review from eellison, mlazos, penguinwu and svekars October 22, 2024 17:54

williamwen42 added the topic: docs topic category label Oct 22, 2024

williamwen42 requested a review from ezyang October 22, 2024 17:55

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

4a8ded6

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Oct 22, 2024

[pt2, docs] Add new PT2 troubleshooting doc

a00179f

ghstack-source-id: 2bb7ff2 Pull Request resolved: #138620

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

5fc7cc9

[ghstack-poisoned]

ezyang reviewed Oct 22, 2024

View reviewed changes

docs/source/torch.compiler.rst Outdated Show resolved Hide resolved

ezyang reviewed Oct 22, 2024

View reviewed changes

docs/source/torch.compiler_custom_backends.rst Outdated Show resolved Hide resolved

ezyang reviewed Oct 22, 2024

View reviewed changes

docs/source/torch.compiler_troubleshooting_old.rst Outdated Show resolved Hide resolved

ezyang reviewed Oct 22, 2024

View reviewed changes

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

cf63237

[ghstack-poisoned]

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

e9a6d78

[ghstack-poisoned]

svekars reviewed Oct 22, 2024

View reviewed changes

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

c48135c

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Oct 22, 2024

[pt2, docs] Add new PT2 troubleshooting doc

d09ba52

ghstack-source-id: 4028b0a Pull Request resolved: #138620

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

df5862a

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Oct 24, 2024

[pt2, docs] Add new PT2 troubleshooting doc

56c8f15

ghstack-source-id: 047bce8 Pull Request resolved: #138620

Apply suggestions from code review

a7000cf

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

21a4680

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Nov 1, 2024

[pt2, docs] Add new PT2 troubleshooting doc

5aecaae

ghstack-source-id: df43264 Pull Request resolved: #138620

ezyang reviewed Nov 2, 2024

View reviewed changes

docs/source/torch.compiler_troubleshooting.rst Outdated Show resolved Hide resolved

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

e194ea1

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Nov 4, 2024

[pt2, docs] Add new PT2 troubleshooting doc

6ca86ff

ghstack-source-id: df45b5f Pull Request resolved: #138620

Update on "[pt2, docs] Add new PT2 troubleshooting doc"

6cb4509

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request Nov 5, 2024

[pt2, docs] Add new PT2 troubleshooting doc

56e71fb

ghstack-source-id: 1091815 Pull Request resolved: #138620

ezyang approved these changes Nov 8, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2024

pytorchmergebot added the merging label Nov 8, 2024

pytorchmergebot removed the merging label Nov 8, 2024

pytorchmergebot added the merging label Nov 9, 2024

pytorchmergebot closed this in be172d2 Nov 9, 2024

pytorchmergebot added Merged and removed merging labels Nov 9, 2024

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024

[pt2, docs] Add new PT2 troubleshooting doc (pytorch#138620)

673386f

Pull Request resolved: pytorch#138620 Approved by: https://github.com/ezyang Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

github-actions bot deleted the gh/williamwen42/151/head branch December 9, 2024 02:14

yushangdi reviewed Jan 29, 2025

View reviewed changes

pianpwk mentioned this pull request Feb 25, 2025

Revamp PT2 TroubleShooting tutorial #126349

Closed

[pt2, docs] Add new PT2 troubleshooting doc #138620

[pt2, docs] Add new PT2 troubleshooting doc #138620

Uh oh!

Conversation

williamwen42 commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138620

❌ 1 New Failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezyang Oct 22, 2024

Choose a reason for hiding this comment

Uh oh!

williamwen42 Oct 22, 2024

Choose a reason for hiding this comment

Uh oh!

svekars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

williamwen42 commented Oct 25, 2024

Uh oh!

Uh oh!

williamwen42 commented Nov 7, 2024

Uh oh!

williamwen42 commented Nov 8, 2024

Uh oh!

pytorchmergebot commented Nov 8, 2024

Merge started

Uh oh!

pytorchmergebot commented Nov 8, 2024

Merge failed

Uh oh!

williamwen42 commented Nov 9, 2024

Uh oh!

pytorchmergebot commented Nov 9, 2024

Merge started

Uh oh!

yushangdi Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williamwen42 Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

yushangdi Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

williamwen42 commented Oct 22, 2024 •

edited

Loading

pytorch-bot bot commented Oct 22, 2024 •

edited

Loading

yushangdi Jan 29, 2025 •

edited

Loading