KEMBAR78
Implement NJT embedding backward by schmidt-jake · Pull Request #138627 · pytorch/pytorch · GitHub
Skip to content

Implement NJT embedding backward #138627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Implement NJT embedding backward #138627

wants to merge 4 commits into from

Conversation

@schmidt-jake
Copy link
Contributor

@schmidt-jake schmidt-jake commented Oct 22, 2024 •
edited
Loading

Fixes #138352

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138627

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3012698 with merge base c0e8458 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@schmidt-jake schmidt-jake changed the title initial attempt! Implement NJT embedding backward Oct 22, 2024
@schmidt-jake
Copy link
Contributor Author

@pytorchbot label "release notes: nested tensor"

@pytorch-bot pytorch-bot bot added the release notes: nested tensor Changes that have a direct impact on nested tensors label Oct 22, 2024
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2024
schmidt-jake
schmidt-jake commented Oct 25, 2024
View reviewed changes
jbschlosser
jbschlosser reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks so much for the PR! Some testing and implementation comments below :)

@schmidt-jake
Copy link
Contributor Author

schmidt-jake commented Oct 25, 2024 •
edited
Loading

@jbschlosser My mind is blown! Thanks for the help. I applied your suggestions in 3012698.

jbschlosser
jbschlosser approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again :)

@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@schmidt-jake schmidt-jake deleted the njt-embedding-backward branch October 29, 2024 19:33
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@schmidt-jake @rahulsingh-intel
Implement NJT embedding backward (pytorch#138627)
4055b23 
Fixes pytorch#138352

Pull Request resolved: pytorch#138627
Approved by: https://github.com/jbschlosser
@jbschlosser jbschlosser mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nested tensor Changes that have a direct impact on nested tensors triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NJT Embedding backward

5 participants

@schmidt-jake @jbschlosser @pytorchmergebot @bdhirsh @pytorchbot