KEMBAR78
Fix test on windows by drisspg · Pull Request #138641 · pytorch/pytorch · GitHub
Skip to content

Fix test on windows #138641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix test on windows #138641

wants to merge 1 commit into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Oct 22, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@drisspg
Fix test on windows
7433744 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138641

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 5 Unrelated Failures

As of commit 7433744 with merge base 1c77b13 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 22, 2024
drisspg added a commit that referenced this pull request Oct 22, 2024
@drisspg
Fix test on windows
63e2c02 
ghstack-source-id: 376fe5d
Pull Request resolved: #138641
@drisspg drisspg mentioned this pull request Oct 22, 2024
Closed
@huydhn huydhn added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR test-config/default labels Oct 22, 2024
huydhn
huydhn approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped! I have add ciflow/periodic to run Windows GPU tests

@drisspg
Copy link
Contributor Author

drisspg commented Oct 23, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: periodic / parallelnative-linux-jammy-py3.9-gcc11 / test (default, 1, 4, lf.linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Oct 23, 2024

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@drisspg @SamGinzburg
Fix test on windows (#138641)
52ca2d7 
Pull Request resolved: #138641
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the gh/drisspg/73/head branch November 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drisspg @pytorchmergebot @huydhn