KEMBAR78
[ONNX] Fix sequence handling in graph building by titaiwangms · Pull Request #138656 · pytorch/pytorch · GitHub
Skip to content

[ONNX] Fix sequence handling in graph building #138656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ONNX] Fix sequence handling in graph building #138656

wants to merge 2 commits into from

Conversation

@titaiwangms
Copy link
Collaborator

Previous to this PR, op.Concat is called without required attributes: axis, and val and arg seems wrongly coded.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 22, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138656

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 10b8e60 with merge base 39bfba3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

titaiwangms
titaiwangms commented Oct 22, 2024
View reviewed changes
justinchuby
justinchuby approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - would it be possible to create unit tests for this? Could you share more on how you discovered this?

@titaiwangms
Copy link
Collaborator Author

I was testing SmolLM_1_7b on benchmarking:

python -m bash_bench.bash_bench_huggingface_big --device cuda --dtype float16 --quiet 0 --memory_peak 0 --exporter onnx_dynamo --model SmolLM_1_7b -r 30 -w 10 --verbose 1 --opt_pattern=ir --verbose 10 --dynamic True

@justinchuby justinchuby changed the title [ONNX] Fix bugs in _building.py [ONNX] Fix sequence handling in _building.py Oct 22, 2024
@justinchuby justinchuby changed the title [ONNX] Fix sequence handling in _building.py [ONNX] Fix sequence handling in graph building Oct 22, 2024
@justinchuby
Copy link
Collaborator

nit: I updated the PR description for it to be more descriptive.

@justinchuby justinchuby mentioned this pull request Oct 22, 2024
Open
@titaiwangms
Copy link
Collaborator Author

Thanks - would it be possible to create unit tests for this? Could you share more on how you discovered this?

I will update a small e2e test in this PR.

@titaiwangms
Copy link
Collaborator Author

I would like to merge this first. I will have the test as follow up.

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2024
@titaiwangms titaiwangms added the topic: bug fixes topic category label Oct 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@titaiwangms @SamGinzburg
[ONNX] Fix sequence handling in graph building (#138656)
453041e 
Previous to this PR, op.Concat is called without required attributes: axis, and val and arg seems wrongly coded.

Pull Request resolved: #138656
Approved by: https://github.com/justinchuby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@titaiwangms @justinchuby @pytorchmergebot @pytorchbot