KEMBAR78
[Pipelining] small comments and variable renames by H-Huang · Pull Request #138735 · pytorch/pytorch · GitHub
Skip to content

[Pipelining] small comments and variable renames #138735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Pipelining] small comments and variable renames #138735

wants to merge 2 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Oct 23, 2024 •
edited
Loading

@H-Huang H-Huang mentioned this pull request Oct 23, 2024
Closed
@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 23, 2024
@H-Huang H-Huang mentioned this pull request Oct 23, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138735

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe9683d with merge base dbd6ada (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@H-Huang H-Huang mentioned this pull request Oct 23, 2024
Closed
@H-Huang H-Huang added release notes: distributed (pipeline) release notes category module: pipelining Pipeline Parallelism labels Oct 24, 2024
@H-Huang
Update on "[Pipelining] small comments and variable renames"
fe9683d 
Addressing the comments in previous PRs to update the variable names and add additional code comments

cc awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
@H-Huang
Copy link
Member Author

H-Huang commented Oct 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@cyyever
Copy link
Collaborator

cyyever commented Oct 25, 2024

@pytorchbot merge -f "Macos pending"

pytorchmergebot pushed a commit that referenced this pull request Oct 25, 2024
@H-Huang @pytorchmergebot
[Pipelining] Clean up hooks in zero bubble (#138720)
2c82f73 
Pull Request resolved: #138720
Approved by: https://github.com/wconstab
ghstack dependencies: #138119, #138504, #138735
@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #138735

@github-actions github-actions bot deleted the gh/H-Huang/149/head branch November 25, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wconstab wconstab wconstab approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging module: pipelining Pipeline Parallelism oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (pipeline) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @pytorchmergebot @cyyever @wconstab