[export] Fix non-strict retracing with kwargs #138927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiming0416
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138927
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1d35e46 with merge base ba74975 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64980053 |
yiming0416
force-pushed
the
export-D64980053
branch
from
7ec4d49 to
b71d76c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64980053 |
yiming0416
added a commit
to yiming0416/pytorch
that referenced
this pull request
Oct 28, 2024
Summary: `torch.fx.Interpreter.run()` only takes args as input. Currently we pass kwargs as well which causes errors during retracing. Flatten the kwargs and concat them with args will solve the issue. Several previously failing tests under `_retraceability_non_strict` now passes. Test Plan: ``` buck2 test @//mode/dev-nosan //caffe2/test:test_export -- -r _retraceability_non_strict ``` Differential Revision: D64980053
angelayi
approved these changes
Oct 28, 2024
yiming0416
force-pushed
the
export-D64980053
branch
from
b71d76c to
206567c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64980053 |
Summary: `torch.fx.Interpreter.run()` only takes args as input. Currently we pass kwargs as well which causes errors during retracing. Flatten the kwargs and concat them with args will solve the issue. Several previously failing tests under `_retraceability_non_strict` now passes. Test Plan: ``` buck2 test @//mode/dev-nosan //caffe2/test:test_export -- -r _retraceability_non_strict ``` Reviewed By: angelayi Differential Revision: D64980053
yiming0416
force-pushed
the
export-D64980053
branch
from
206567c to
1d35e46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64980053 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Oct 29, 2024
Summary: `torch.fx.Interpreter.run()` only takes args as input. Currently we pass kwargs as well which causes errors during retracing. Flatten the kwargs and concat them with args will solve the issue. Several previously failing tests under `_retraceability_non_strict` now passes. Test Plan: ``` buck2 test @//mode/dev-nosan //caffe2/test:test_export -- -r _retraceability_non_strict ``` Differential Revision: D64980053 Pull Request resolved: pytorch#138927 Approved by: https://github.com/angelayi
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Summary: `torch.fx.Interpreter.run()` only takes args as input. Currently we pass kwargs as well which causes errors during retracing. Flatten the kwargs and concat them with args will solve the issue. Several previously failing tests under `_retraceability_non_strict` now passes. Test Plan: ``` buck2 test @//mode/dev-nosan //caffe2/test:test_export -- -r _retraceability_non_strict ``` Differential Revision: D64980053 Pull Request resolved: pytorch#138927 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torch.fx.Interpreter.run()only takes args as input. Currently we pass kwargs as well which causes errors during retracing.Flatten the kwargs and concat them with args will solve the issue.
Several previously failing tests under
_retraceability_non_strictnow passes.Test Plan:
Differential Revision: D64980053