[inductor] getting AOT inductor to treat None args correctly #139114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139114
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 142cdc9 with merge base 2922b9f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
aakhundov
reviewed
Oct 28, 2024
torch/_inductor/ir.py
Outdated
Comment on lines
5427
to
5449
| # We have to compute the constexpr indices for the new, filtered raw_args | ||
| # We also have to adjust equal_to_1. | ||
| eq1_indices_set = set(triton_meta["configs"][0].equal_to_1) | ||
| constexpr_indices = [] | ||
| equal_to_1 = [] | ||
| index_shift = 0 | ||
| for idx, kwarg in enumerate(self.ordered_kwargs_for_cpp_kernel): | ||
| # every time we encounter an idx we removed, adjust by one to account for it | ||
| # So for example if we had [None, const X] | ||
| # iter 1: | ||
| # None was removed, adjust=1 | ||
| # iter 2: | ||
| # X is const at idx=1, but the adjusted idx is 0 now, because None was removed | ||
| if idx in removed_none_args: | ||
| index_shift += 1 | ||
| continue | ||
| arg_index = kernel.arg_names.index(kwarg) | ||
| if arg_index in kernel.constexprs: | ||
| constexpr_indices.append(idx - index_shift) | ||
| if arg_index in eq1_indices_set: | ||
| equal_to_1.append(idx - index_shift) | ||
|
|
||
| triton_meta["configs"][0].equal_to_1 = equal_to_1 |
There was a problem hiding this comment.
Do this only if removed_none_args?
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
|
@SamGinzburg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aakhundov
approved these changes
Oct 29, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…#139114) Differential Revision: [D65102228](https://our.internmc.facebook.com/intern/diff/D65102228) Pull Request resolved: pytorch#139114 Approved by: https://github.com/aakhundov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
Differential Revision: D65102228