[export] Remove custom forward func in swap #139126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
angelayi
requested review from
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139126
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a25e6e7 with merge base ad93357 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D65100694](https://our.internmc.facebook.com/intern/diff/D65100694) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65100694 |
angelayi
added a commit
that referenced
this pull request
Oct 29, 2024
Pull Request resolved: #139126 @imported-using-ghimport Differential Revision: [D65100694](https://our.internmc.facebook.com/intern/diff/D65100694/) ghstack-source-id: 250713739
angelayi
changed the title
avikchaudhuri
approved these changes
Oct 29, 2024
| } | ||
|
|
||
| gm = ep.module() | ||
| gm.validate_inputs = False # type: ignore[assignment] |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Differential Revision: [D65100694](https://our.internmc.facebook.com/intern/diff/D65100694) Remove the custom forward function and instead move the pytree flatten/unflatten ops into the graph. This allows us to natively run via the interpreter. Pull Request resolved: pytorch#139126 Approved by: https://github.com/avikchaudhuri
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
ghstack-source-id: eeefdaf Pull Request resolved: pytorch/pytorch#139126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D65100694
Remove the custom forward function and instead move the pytree flatten/unflatten ops into the graph. This allows us to natively run via the interpreter.