[Autotune Inductor] Some clean up and dataclassing #139157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139157
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit adb0c92 with merge base 77e25d5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
Oct 29, 2024
Skylion007
reviewed
Oct 29, 2024
Skylion007
previously approved these changes
Oct 29, 2024
eellison
reviewed
Oct 30, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Pull Request resolved: pytorch#139157 Approved by: https://github.com/eellison
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 5, 2024
# Summary Arg ordering was wrong for when dynamic shapes is enabled and we pass in the additional size args Pull Request resolved: #139777 Approved by: https://github.com/eellison ghstack dependencies: #139157
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Summary Arg ordering was wrong for when dynamic shapes is enabled and we pass in the additional size args Pull Request resolved: pytorch#139777 Approved by: https://github.com/eellison ghstack dependencies: pytorch#139157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov