KEMBAR78
[PT2E][Quant] Remove Redundant Method in X86 Quantizer by leslie-fang-intel · Pull Request #139161 · pytorch/pytorch · GitHub
Skip to content

Conversation

@leslie-fang-intel
Copy link
Collaborator

@leslie-fang-intel leslie-fang-intel commented Oct 29, 2024

Stack from ghstack (oldest at bottom):

Summary
Remove the redundant method of X86 Inductor Quantizer as get_supported_quantization_configs, get_supported_operator_for_quantization_config and get_supported_operators. They are not the must have to implement a customized Quantizer and not mentioned in existing document for how to use X86 Inductor Quantizer.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139161

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit de85848 with merge base e80fe7f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@leslie-fang-intel leslie-fang-intel marked this pull request as draft October 29, 2024 06:37
@leslie-fang-intel leslie-fang-intel added ciflow/trunk Trigger trunk jobs on your pull request suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Oct 29, 2024
[ghstack-poisoned]
leslie-fang-intel added a commit that referenced this pull request Oct 29, 2024
@leslie-fang-intel
Copy link
Collaborator Author

@pytorchbot merge

@leslie-fang-intel leslie-fang-intel marked this pull request as ready for review October 30, 2024 03:24
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
**Summary**
Remove the redundant method of X86 Inductor Quantizer as `get_supported_quantization_configs`, `get_supported_operator_for_quantization_config` and `get_supported_operators`. They are not the must have to implement a customized Quantizer and not mentioned in existing document for how to use X86 Inductor Quantizer.

Pull Request resolved: pytorch#139161
Approved by: https://github.com/jgong5
@github-actions github-actions bot deleted the gh/leslie-fang-intel/156/head branch November 30, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: AO frontend release notes: quantization release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants