KEMBAR78
Export XPU oneDNN header to the public by guangyey · Pull Request #139177 · pytorch/pytorch · GitHub
Skip to content

Export XPU oneDNN header to the public #139177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Export XPU oneDNN header to the public #139177

wants to merge 5 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 29, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Motivation

Export oneDNN header to the public, for example, the third-party extension now could use GpuStreamManager to manage dnnl::stream to submit oneDNN kernel.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 29, 2024
@guangyey guangyey mentioned this pull request Oct 29, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139177

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 62f3275 with merge base 23d590e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey added a commit that referenced this pull request Oct 29, 2024
@guangyey
Export XPU oneDNN header to public
0a65ed5 
ghstack-source-id: 3d8bc77
Pull Request resolved: #139177
@guangyey guangyey changed the title Export XPU oneDNN header to public Export XPU oneDNN header to the public Oct 29, 2024
@guangyey guangyey marked this pull request as draft October 29, 2024 09:58
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label Oct 29, 2024
@guangyey guangyey changed the title Export XPU oneDNN header to the public [WIP] Export XPU oneDNN header to the public Oct 29, 2024
guangyey added a commit that referenced this pull request Oct 29, 2024
@guangyey
Export XPU oneDNN header to public
09e4545 
ghstack-source-id: 7476026
Pull Request resolved: #139177
@guangyey
Update
69a40f8 
[ghstack-poisoned]
@guangyey
Update
4be3ee9 
[ghstack-poisoned]
@guangyey guangyey changed the title [WIP] Export XPU oneDNN header to the public Export XPU oneDNN header to the public Oct 30, 2024
@guangyey guangyey marked this pull request as ready for review October 30, 2024 05:50
@guangyey guangyey added release notes: xpu release notes category ciflow/trunk Trigger trunk jobs on your pull request and removed topic: not user facing topic category labels Oct 30, 2024
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase

@guangyey guangyey requested review from atalman and malfet October 30, 2024 06:47
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Update
45938bb 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/84/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/139177)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 30, 2024
@guangyey
Copy link
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command '['ghstack']' returned non-zero exit status 1.
Raised by https://github.com/pytorch/pytorch/actions/runs/11590469912

guangyey added a commit that referenced this pull request Oct 30, 2024
@guangyey
Export XPU oneDNN header to public
14d6556 
ghstack-source-id: 4ce6772
Pull Request resolved: #139177
@guangyey
Update
8a55258 
[ghstack-poisoned]
@guangyey
Update
62f3275 
[ghstack-poisoned]
@guangyey guangyey requested a review from ezyang October 31, 2024 08:52
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 1, 2024

@malfet @atalman @ezyang May I know if could you help review this PR?

malfet
malfet approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though in the long run it should be made conditional on build option

@guangyey
Copy link
Collaborator Author

guangyey commented Nov 1, 2024

Thanks, @malfet I will file another PR to improve them by conditional of build option

@guangyey
Copy link
Collaborator Author

guangyey commented Nov 1, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey guangyey mentioned this pull request Nov 1, 2024
Closed
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@guangyey @rahulsingh-intel
Export XPU oneDNN header to the public (pytorch#139177)
99299ef 
# Motivation
Export oneDNN header to the public, for example, the third-party extension now could use `GpuStreamManager` to manage `dnnl::stream` to submit oneDNN kernel.
Pull Request resolved: pytorch#139177
Approved by: https://github.com/gujinghui, https://github.com/EikanWang, https://github.com/malfet
@github-actions github-actions bot deleted the gh/guangyey/84/head branch December 2, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@gujinghui gujinghui gujinghui approved these changes

@EikanWang EikanWang EikanWang approved these changes

@atalman atalman Awaiting requested review from atalman

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source release notes: xpu release notes category topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@guangyey @pytorchmergebot @malfet @gujinghui @EikanWang @pytorchbot