[AOTI] Update zero size computation in clone_preserve_strides #139224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. While we can fix that by updating the size computation, it makes more sense to unify with clone_preserve_strides from _prims_common. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139224
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2a14b45 with merge base ad0883a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
angelayi
approved these changes
Oct 29, 2024
…des" Summary: clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Fix that. [ghstack-poisoned]
desertfire
changed the title
…des" Summary: clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Fix that. [ghstack-poisoned]
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@desertfire your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 31, 2024
…#139224)" This reverts commit 206a8dd. Reverted #139224 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#139224 (comment)))
desertfire
added a commit
that referenced
this pull request
Nov 1, 2024
Summary: Reland #139224. clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
…#139458) Summary: Reland #139224. clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Differential Revision: [D65317451](https://our.internmc.facebook.com/intern/diff/D65317451) Pull Request resolved: #139458 Approved by: https://github.com/hl475
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…h#139224) Summary: clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Fix that. Differential Revision: [D65250405](https://our.internmc.facebook.com/intern/diff/D65250405) Pull Request resolved: pytorch#139224 Approved by: https://github.com/angelayi
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…pytorch#139224)" This reverts commit 206a8dd. Reverted pytorch#139224 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#139224 (comment)))
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…pytorch#139458) Summary: Reland pytorch#139224. clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Differential Revision: [D65317451](https://our.internmc.facebook.com/intern/diff/D65317451) Pull Request resolved: pytorch#139458 Approved by: https://github.com/hl475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: clone_preserve_strides implemented in _inductor/utils.py does not handle multi-dimensional 0-size tensor correctly. Fix that.
Differential Revision: D65250405
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov