[dynamo][NFC] Rename mutable_local and add documentation
#139339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139339
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9720765 with merge base b82a51b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 30, 2024
StrongerXi
requested review from
anijain2305,
jansel,
mlazos and
williamwen42
jansel
approved these changes
Oct 31, 2024
anijain2305
reviewed
Nov 4, 2024
|
|
||
|
|
||
| class MutableSideEffects(MutableLocalBase): | ||
| class ValueMutationExisting(MutationType): |
There was a problem hiding this comment.
Move these to base.py? Thinking if all these are better to have in one file.
There was a problem hiding this comment.
It's in the next patch, wanted to make review easier:) #139340
mlazos
approved these changes
Nov 4, 2024
anijain2305
approved these changes
Nov 4, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…139340) As title, this addresses https://github.com/pytorch/pytorch/pull/137905/files#r1806800222. Pull Request resolved: #139340 Approved by: https://github.com/anijain2305 ghstack dependencies: #139339
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…Tracker` (#139341) This patch adds 2 simple methods `VariableTracker.is_mutable()` and `VariableTracker.is_immutable()`, which helps clarify intention. For instance, rather than writing ```python if var.mutation_type: ... ``` After this patch one can write ```python if var.is_mutable(): ... ``` This patch also simplifies `mutation_type` propagation in some `ListVariable` methods. Pull Request resolved: #139341 Approved by: https://github.com/mlazos, https://github.com/anijain2305 ghstack dependencies: #139339, #139340
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…39339) This patch addresses the renaming part of pytorch#133027, specifically, it renames the following and adds documentation for relevant classes. 1. `VariableTracker.mutable_local` to `mutation_type` 2. `MatableLocal `to `ValueMutationNew` 3. `MutableSideEffects `to `ValueMutationExisting` 4. `MutableLocalSource` to `SourceType` 5. `MutableLocalSource.Local` to `New` Note that (2), (3) and (5) are mainly to bring consistency between them and `AttributeMutationNew`, `AttributeMutationExisting`. Pull Request resolved: pytorch#139339 Approved by: https://github.com/jansel, https://github.com/mlazos, https://github.com/anijain2305
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#139340) As title, this addresses https://github.com/pytorch/pytorch/pull/137905/files#r1806800222. Pull Request resolved: pytorch#139340 Approved by: https://github.com/anijain2305 ghstack dependencies: pytorch#139339
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…Tracker` (pytorch#139341) This patch adds 2 simple methods `VariableTracker.is_mutable()` and `VariableTracker.is_immutable()`, which helps clarify intention. For instance, rather than writing ```python if var.mutation_type: ... ``` After this patch one can write ```python if var.is_mutable(): ... ``` This patch also simplifies `mutation_type` propagation in some `ListVariable` methods. Pull Request resolved: pytorch#139341 Approved by: https://github.com/mlazos, https://github.com/anijain2305 ghstack dependencies: pytorch#139339, pytorch#139340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
is_mutable()andis_immutable()methods toVariableTracker#139341MutationTypeclasses intovariables/base.py#139340mutable_localand add documentation #139339This patch addresses the renaming part of #133027, specifically, it
renames the following and adds documentation for relevant classes.
VariableTracker.mutable_localtomutation_typeMatableLocaltoValueMutationNewMutableSideEffectstoValueMutationExistingMutableLocalSourcetoSourceTypeMutableLocalSource.LocaltoNewNote that (2), (3) and (5) are mainly to bring consistency between them
and
AttributeMutationNew,AttributeMutationExisting.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames