KEMBAR78
Fix flex_decode to build offsets off of strides by drisspg · Pull Request #139516 · pytorch/pytorch · GitHub
Skip to content

Fix flex_decode to build offsets off of strides #139516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix flex_decode to build offsets off of strides #139516

wants to merge 2 commits into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 1, 2024 •
edited by pytorchmergebot
Loading

@drisspg
Update
08ce8df 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139516

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 12d81eb with merge base 0dbc284 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg mentioned this pull request Nov 1, 2024
Closed
@drisspg
Copy link
Contributor Author

drisspg commented Nov 2, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@drisspg
Update
12d81eb 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/drisspg/77/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/139516)

pytorchmergebot pushed a commit that referenced this pull request Nov 2, 2024
@drisspg
Fix flex_decode to build offsets off of strides
65be3e2 
ghstack-source-id: fad9525
Pull Request resolved: #139516
@drisspg
Copy link
Contributor Author

drisspg commented Nov 2, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 2, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@drisspg @rahulsingh-intel
Fix flex_decode to build offsets off of strides (pytorch#139516)
47a651e 
Fixes PR: pytorch#139462

Pull Request resolved: pytorch#139516
Approved by: https://github.com/Chillee
@github-actions github-actions bot deleted the gh/drisspg/77/head branch December 3, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: flex attention module: inductor release notes: nn release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drisspg @pytorchmergebot @Chillee