KEMBAR78
[Intel GPU] format XPU oneDNN integration codes by ZhiweiYan-96 · Pull Request #139721 · pytorch/pytorch · GitHub
Skip to content

[Intel GPU] format XPU oneDNN integration codes #139721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[Intel GPU] format XPU oneDNN integration codes #139721

wants to merge 14 commits into from

Conversation

@ZhiweiYan-96
Copy link
Collaborator

@ZhiweiYan-96 ZhiweiYan-96 commented Nov 5, 2024 •
edited by pytorch-bot bot
Loading

@ZhiweiYan-96
Update
159e26c 
[ghstack-poisoned]
This was referenced Nov 5, 2024
Closed
Closed
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 5, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139721

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e55b68d with merge base ffb9790 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ZhiweiYan-96 ZhiweiYan-96 marked this pull request as draft November 5, 2024 05:50
@ZhiweiYan-96
Update
6ad988b 
[ghstack-poisoned]
@guangyey guangyey requested a review from cyyever November 5, 2024 06:01
@guangyey guangyey added the topic: improvements topic category label Nov 5, 2024
@cyyever
Copy link
Collaborator

cyyever commented Nov 5, 2024

Lots of formatting are required.

@ZhiweiYan-96
Update
8f97a28 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Nov 5, 2024
@guangyey
Copy link
Collaborator

guangyey commented Nov 5, 2024

Lots of formatting are required.

Thanks, I will re-request your review when this PR is done.

@ZhiweiYan-96 ZhiweiYan-96 added ciflow/xpu Run XPU CI tasks ciflow/trunk Trigger trunk jobs on your pull request labels Nov 5, 2024
@EikanWang EikanWang marked this pull request as ready for review November 5, 2024 12:19
@EikanWang EikanWang requested review from atalman and malfet November 5, 2024 12:21
@ZhiweiYan-96
Update
8d528a5 
[ghstack-poisoned]
@EikanWang
Copy link
Collaborator

Pls. ensure the ci signal is green

@ZhiweiYan-96
Copy link
Collaborator Author

@etaf is handling this CI issue. I would rebase the PR once the issue fixed.

@ZhiweiYan-96
Update
0177bd5 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/ZhiweiYan-96/36/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging aten/src/ATen/native/mkldnn/xpu/Blas.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/mkldnn/xpu/Blas.cpp
error: could not apply a6ec6f32a3... [Intel GPU] format XPU oneDNN integration codes
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Could not apply a6ec6f32a3... [Intel GPU] format XPU oneDNN integration codes

Raised by https://github.com/pytorch/pytorch/actions/runs/11763022477

@ZhiweiYan-96
Update
5a65be0 
[ghstack-poisoned]
@ZhiweiYan-96
Update
66f3481 
[ghstack-poisoned]
@ZhiweiYan-96
Update
97c09ac 
[ghstack-poisoned]
@ZhiweiYan-96
Update
4f05dea 
[ghstack-poisoned]
@ZhiweiYan-96
Update
5410584 
[ghstack-poisoned]
@ZhiweiYan-96
Update
fa822cf 
[ghstack-poisoned]
@ZhiweiYan-96
Update
e55b68d 
[ghstack-poisoned]
@ZhiweiYan-96
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 12, 2024
@ZhiweiYan-96 @pytorchmergebot
[Intel GPU] Extract common utils for conv&qconv (#139580)
19eff28 
# Motivation
This PR is a precursor to #133080. The PR extracts common logics in convolution and quantized convolution into `Utils.cpp`. With such modification, these two operators could share codes like input format querying, op layout querying.

Pull Request resolved: #139580
Approved by: https://github.com/EikanWang, https://github.com/guangyey, https://github.com/malfet
ghstack dependencies: #139721
@ZhiweiYan-96 ZhiweiYan-96 mentioned this pull request Nov 19, 2024
Closed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@ZhiweiYan-96
[Intel GPU] format XPU oneDNN integration codes (pytorch#139721)
8632c52 
# Motivation
This PR add XPU oneDNN integration codes into lintrunner config `.lintrunner.toml`, which would format cpp source and cpp headers codes at `aten/src/ATen/native/mkldnn/xpu/` and `aten/src/ATen/native/mkldnn/xpu/detail/`

Pull Request resolved: pytorch#139721
Approved by: https://github.com/guangyey, https://github.com/cyyever, https://github.com/EikanWang, https://github.com/Skylion007, https://github.com/malfet
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@ZhiweiYan-96
[Intel GPU] Extract common utils for conv&qconv (pytorch#139580)
dffecc6 
# Motivation
This PR is a precursor to pytorch#133080. The PR extracts common logics in convolution and quantized convolution into `Utils.cpp`. With such modification, these two operators could share codes like input format querying, op layout querying.

Pull Request resolved: pytorch#139580
Approved by: https://github.com/EikanWang, https://github.com/guangyey, https://github.com/malfet
ghstack dependencies: pytorch#139721
@github-actions github-actions bot deleted the gh/ZhiweiYan-96/36/head branch December 12, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@cyyever cyyever cyyever approved these changes

@EikanWang EikanWang EikanWang approved these changes

@guangyey guangyey guangyey approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor open source topic: improvements topic category topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ZhiweiYan-96 @cyyever @guangyey @EikanWang @pytorchmergebot @Skylion007 @malfet @pytorchbot