Do not try to optimize new implications in get_implications #139738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139738
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 236c721 with merge base 5008d15 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
release notes: fx
ezyang
approved these changes
Nov 5, 2024
Summary: save around 8% on the torchrec model. In most case the new implications are not optimizaiton anyway in some case though they are, but optimizing them is useless. ex: ``` generating implications for Eq(Mod(s0, 3), 0) adding Eq(Mod(s0, 3), 0) adding Eq(0, Mod(s0, 3)) adding Ne(Mod(s0, 3), 0) adding Ne(0, Mod(s0, 3)) adding Mod(s0, 3) <= 0 adding 0 < Mod(s0, 3) adding True adding False ``` VS ``` generating implications for Eq(Mod(s0, 3), 0) adding Eq(Mod(s0, 3), 0) adding Eq(0, Mod(s0, 3)) adding Ne(Mod(s0, 3), 0) adding Ne(0, Mod(s0, 3)) adding Mod(s0, 3) <= 0 adding 0 < Mod(s0, 3) adding 0 <= Mod(s0, 3) adding Mod(s0, 3) < 0 ``` the main difference is that 0 <= Mod(s0, 3) can be simplified to True and Mod(s0, 3) < 0 to False but with this change this wont happen. but True:True and False: False are useless anyway lol. so its ok i think ``` buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=1000 ``` <img width="1082" alt="Screenshot 2024-11-04 at 9 25 51 PM" src="https://github.com/user-attachments/assets/a26e291b-9280-4b55-9275-f3201a36ac51"> cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…139738) Summary: save around 8% on the torchrec model. In most case the new implications are not optimizaiton anyway in some case though they are, but optimizing them is useless. ex: ``` generating implications for Eq(Mod(s0, 3), 0) adding Eq(Mod(s0, 3), 0) adding Eq(0, Mod(s0, 3)) adding Ne(Mod(s0, 3), 0) adding Ne(0, Mod(s0, 3)) adding Mod(s0, 3) <= 0 adding 0 < Mod(s0, 3) adding True adding False ``` VS ``` generating implications for Eq(Mod(s0, 3), 0) adding Eq(Mod(s0, 3), 0) adding Eq(0, Mod(s0, 3)) adding Ne(Mod(s0, 3), 0) adding Ne(0, Mod(s0, 3)) adding Mod(s0, 3) <= 0 adding 0 < Mod(s0, 3) adding 0 <= Mod(s0, 3) adding Mod(s0, 3) < 0 ``` the main difference is that 0 <= Mod(s0, 3) can be simplified to True and Mod(s0, 3) < 0 to False but with this change this wont happen. but True:True and False: False are useless anyway lol. so its ok i think ``` buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=1000 ``` <img width="1082" alt="Screenshot 2024-11-04 at 9 25 51 PM" src="https://github.com/user-attachments/assets/a26e291b-9280-4b55-9275-f3201a36ac51"> Pull Request resolved: pytorch#139738 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#139703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
save around 8% on the torchrec model.
In most case the new implications are not optimizaiton anyway in some case though they are,
but optimizing them is useless.
ex:
VS
the main difference is that 0 <= Mod(s0, 3) can be simplified to True and Mod(s0, 3) < 0 to False but with this change
this wont happen. but True:True and False: False are useless anyway lol. so its ok i think
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames