KEMBAR78
Add current FSDP2 path to old composable FSDP1 warning by awgu · Pull Request #139759 · pytorch/pytorch · GitHub
Skip to content

Add current FSDP2 path to old composable FSDP1 warning #139759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add current FSDP2 path to old composable FSDP1 warning #139759

wants to merge 1 commit into from

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Nov 5, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139759

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit cf00e81 with merge base 0e4d426 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Nov 5, 2024
awgu pushed a commit that referenced this pull request Nov 5, 2024
Add current FSDP2 path to old composable FSDP1 warning
da5efdc 
ghstack-source-id: 7ed2791
Pull Request resolved: #139759
@awgu awgu added the release notes: distributed (fsdp) release notes category label Nov 5, 2024
@awgu awgu marked this pull request as ready for review November 5, 2024 18:55
@awgu awgu requested review from fegin, weifengpy and wz337 November 5, 2024 18:55
@awgu
Copy link
Collaborator Author

awgu commented Nov 5, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge), pull / cuda12.1-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wz337
wz337 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@awgu
Copy link
Collaborator Author

awgu commented Nov 5, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 7 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge), pull / cuda12.1-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu), linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@awgu
Copy link
Collaborator Author

awgu commented Nov 6, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 8 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge), pull / cuda12.1-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu), linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build, trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Add current FSDP2 path to old composable FSDP1 warning (pytorch#139759)
6d7ecbc 
Pull Request resolved: pytorch#139759
Approved by: https://github.com/weifengpy, https://github.com/wz337
ghstack dependencies: pytorch#139650
@github-actions github-actions bot deleted the gh/awgu/656/head branch December 6, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wz337 wz337 wz337 approved these changes

@weifengpy weifengpy weifengpy approved these changes

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@awgu @pytorchmergebot @wz337 @weifengpy