KEMBAR78
[BE]: Add NT missing fp classification functions by Skylion007 · Pull Request #139890 · pytorch/pytorch · GitHub
Skip to content

[BE]: Add NT missing fp classification functions #139890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE]: Add NT missing fp classification functions #139890

wants to merge 2 commits into from

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Nov 6, 2024 •
edited
Loading

Follow up to some issues @malfet's recent PR pointed out about missing ops #139763. Tried to mirror it to other important nearby ops. Seems like we could automate / autogen this more for generic pointwise ops like this.

cc @cpuhrsch @jbschlosser @bhosmer @drisspg @soulitzer @davidberard98 @YuqingJ

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139890

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe10358 with merge base 59cf4bc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added the module: nestedtensor NestedTensor tag see issue #25032 label Nov 6, 2024
@Skylion007 Skylion007 force-pushed the skylion007/implement-missing-nt-classif-funcs-2024-11-06 branch from d6abe10 to ec7644b Compare November 6, 2024 15:40
@Skylion007 Skylion007 added release notes: nested tensor Changes that have a direct impact on nested tensors and removed module: nestedtensor NestedTensor tag see issue #25032 labels Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@Skylion007 Skylion007 requested review from drisspg and malfet November 6, 2024 15:43
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Nov 6, 2024
@Skylion007 Skylion007 force-pushed the skylion007/implement-missing-nt-classif-funcs-2024-11-06 branch from ec7644b to bae4a52 Compare November 6, 2024 16:01
@Skylion007 Skylion007 requested review from atalman and ezyang November 6, 2024 16:38
Skylion007
Skylion007 commented Nov 6, 2024
View reviewed changes
malfet
malfet approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the followup

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@Skylion007
[BE]: Add NT missing fp classification functions (pytorch#139890)
a0990ef 
Follow up to some issues @malfet's recent PR pointed out about missing ops pytorch#139763. Tried to mirror it to other important nearby ops. Seems like we could automate / autogen this more for generic pointwise ops like this.

Pull Request resolved: pytorch#139890
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@drisspg drisspg Awaiting requested review from drisspg

@ezyang ezyang Awaiting requested review from ezyang

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nested tensor Changes that have a direct impact on nested tensors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skylion007 @pytorchmergebot @malfet @pytorchbot