Add conda install to Manylinux 2_28 images #139894
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139894
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7522955 with merge base dd6a5de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot merge -f "lint and manylinux jobs are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
IMO we should revert this change: if Nova workflow uses conda, we should build separate images, but manywheel ones should stay conda free |
This way we can use these images instead of conda-build images for all workflows in test-infra. Please note: - I am using existing conda install script, thats alredy used in https://github.com/pytorch/pytorch/blob/main/.ci/docker/conda/Dockerfile#L47 - PR with update to miniforge will be posted as followup Pull Request resolved: pytorch#139894 Approved by: https://github.com/Skylion007, https://github.com/seemethere
This way we can use these images instead of conda-build images for all workflows in test-infra. Please note: - I am using existing conda install script, thats alredy used in https://github.com/pytorch/pytorch/blob/main/.ci/docker/conda/Dockerfile#L47 - PR with update to miniforge will be posted as followup Pull Request resolved: pytorch#139894 Approved by: https://github.com/Skylion007, https://github.com/seemethere
5 participants
This way we can use these images instead of conda-build images for all workflows in test-infra.
Please note: