KEMBAR78
Remove most rockset references by clee2000 · Pull Request #139922 · pytorch/pytorch · GitHub
Skip to content

Remove most rockset references #139922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove most rockset references #139922

wants to merge 4 commits into from

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Nov 6, 2024 •
edited
Loading

Remove most references to rockset:

  • replace comments and docs with a generic "backend database"
  • Delete upload_to_rockset, so we no longer need to install the package.
  • Do not upload perf stats to rockset as well (we should be completely on DynamoDB now right @huydhn?)

According to VSCode, it went from 41 -> 7 instances of "rockset" in the repo

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 6, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139922

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8aee590 with merge base 4715b77 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 force-pushed the csl/remove_most_rs_refs branch from 228be0c to 41d1ed0 Compare November 8, 2024 03:24
@clee2000 clee2000 force-pushed the csl/remove_most_rs_refs branch from 41d1ed0 to 8e450b2 Compare November 8, 2024 03:33
@clee2000 clee2000 marked this pull request as ready for review November 8, 2024 03:37
@clee2000 clee2000 requested review from a team and jeffdaily as code owners November 8, 2024 03:37
huydhn
huydhn approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up! I notice that there is one TODO that is assigned to me, but haven't had time to follow-up on it

@huydhn
Copy link
Contributor

huydhn commented Nov 12, 2024

Do not upload perf stats to rockset as well (we should be completely on DynamoDB now right @huydhn?)

Yes, they are all on DynamoDB now. The only one left is ao, but ao runs from torchbench https://github.com/pytorch/benchmark/blob/main/.github/workflows/torchao.yml, so it shouldn't touch any of the code path here

@clee2000
Copy link
Contributor Author

@pytorchbot merge -f "no trunk needed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@clee2000
Remove most rockset references (pytorch#139922)
e7d339e 
Remove most references to rockset:
* replace comments and docs with a generic "backend database"
* Delete `upload_to_rockset`, so we no longer need to install the package.
* Do not upload perf stats to rockset as well (we should be completely on DynamoDB now right @huydhn?)

According to VSCode, it went from 41 -> 7 instances of "rockset" in the repo
Pull Request resolved: pytorch#139922
Approved by: https://github.com/huydhn, https://github.com/ZainRizvi
@github-actions github-actions bot deleted the csl/remove_most_rs_refs branch December 14, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clee2000 @huydhn @pytorchmergebot @ZainRizvi