Build magma for windows #139924
Build magma for windows #139924
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139924
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0aac8a3 with merge base c1c94cb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Will update this PR once #139888 is merged, to use the same upload script. |
afrittoli
force-pushed
the
magma_windows
branch
from
e8e7874 to
45fb759
Compare
This is a first step towards removing builds dependency to conda. Currently we build magma as a conda package in a pytorch conda channel, implemented in https://github.com/pytorch/builder/tree/main/magma. This commit adapts the logic from pytorch/builder as follows: - use pytorch/manylinux-cuda<cuda-version> as base image - apply patches and invoke the build.sh script directly (not anymore through conda build) - stores license and build files along with the built artifact, in an info subfolder - create a tarball file which resembles that created by conda, without any conda-specific metadata A new matrix workflow is added, which runs the build for each supported cuda version, and uploads the binaries to pyorch s3 bucket. For the upload, define an upload.sh script, which will be used by the magma windows job as well, to upload to s3://ossci-* buckets. The build runs on PR and push, upload runs in DRY_RUN mode in case of PR. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Copy the magma for windows job and script from pytorch/builder https://github.com/pytorch/builder/blob/c9aac65e12734a16d9c285c366bcbf6cc0c67e43/.github/workflows/build-magma-windows.yml The linux version is moved here in pytorch#139888 Use the upload_aws_ossci.sh upload script used by the linux magma builds as well. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
magma_windows
branch
from
45fb759 to
0aac8a3
Compare
colesbury
added
the
triaged
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Comment with id 2465845977 not found Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Copy the magma for windows job and script from pytorch/builder https://github.com/pytorch/builder/blob/c9aac65e12734a16d9c285c366bcbf6cc0c67e43/.github/workflows/build-magma-windows.yml The linux version is moved here in pytorch#139888 Fixes pytorch#140001 Pull Request resolved: pytorch#139924 Approved by: https://github.com/atalman
5 participants
Copy the magma for windows job and script from pytorch/builder https://github.com/pytorch/builder/blob/c9aac65e12734a16d9c285c366bcbf6cc0c67e43/.github/workflows/build-magma-windows.yml
The linux version is moved here in #139888
Fixes #140001