[MPS] Restrict MSELoss to floating types #139960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139960
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1cad70b with merge base 59cf4bc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
This was referenced Nov 7, 2024
malfet
added a commit
that referenced
this pull request
Nov 7, 2024
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl` Fixes #139723 ghstack-source-id: 6cd80ca Pull Request resolved: #139960
kimishpatel
approved these changes
Nov 7, 2024
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl` Fixes pytorch#139723 Pull Request resolved: pytorch#139960 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#139961, pytorch#139959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU
Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out
Fix function name for
mse_loss_out_mpsas__func__for any structured op implementation isimplFixes #139723