Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

laithsakka · 2024-11-07T18:22:21Z

Stack from ghstack (oldest at bottom):

-> Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

with 20K features saves 20 seconds.
257.021589517593-> 237.8304626941681
buck2 run @fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2024-11-07T18:22:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140027

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[DomainsOnly] Jobs fail with GLIBC version not found

✅ No Failures

As of commit 8ef839d with merge base 1c1d06a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv [ghstack-poisoned]

ghstack-source-id: c9096ee Pull Request resolved: #140027

laithsakka · 2024-11-08T00:32:48Z

WIN: benchmark ('update_hint_regression', 'compile_time_instruction_count') failed, actual result 1696567937 is -3.05% lower than expected 1750000000 ±2.00% please update the expected results. 

please update all results that changed significantly, and not only the failed ones
WIN: benchmark ('sum_floordiv_regression', 'compile_time_instruction_count') failed, actual result 1096619420 is -5.46% lower than expected 1160000000 ±1.50% please update the expected results.

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv [ghstack-poisoned]

ghstack-source-id: b3ec8be Pull Request resolved: #140027

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 709556b Pull Request resolved: #140027

torch/fx/experimental/symbolic_shapes.py

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 1958a08 Pull Request resolved: #140027

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 716347f Pull Request resolved: #140027

torch/fx/experimental/symbolic_shapes.py

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 4a72407 Pull Request resolved: #140027

…d_symbols)" with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 91754f6 Pull Request resolved: #140027

laithsakka · 2024-11-15T16:03:42Z

@pytorchbot merge

pytorchmergebot · 2024-11-15T16:05:36Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ytorch#140027) with 20K features saves 20 seconds. 257.021589517593-> 237.8304626941681 buck2 run @fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000 Pull Request resolved: pytorch#140027 Approved by: https://github.com/ezyang

use has_free_unbacked_symbols

efa4352

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Nov 7, 2024

facebook-github-bot added the fx label Nov 7, 2024

laithsakka changed the title ~~use has_free_unbacked_symbols~~ use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) Nov 7, 2024

laithsakka requested review from aorenste and ezyang November 7, 2024 18:24

laithsakka added a commit that referenced this pull request Nov 7, 2024

use has_free_unbacked_symbols

be01ae7

ghstack-source-id: c9096ee Pull Request resolved: #140027

laithsakka removed request for aorenste and ezyang November 7, 2024 18:48

laithsakka marked this pull request as draft November 7, 2024 18:48

laithsakka requested review from aorenste, bobrenjc93 and ezyang November 7, 2024 18:56

laithsakka marked this pull request as ready for review November 7, 2024 18:56

laithsakka requested a review from isuruf November 8, 2024 00:33

laithsakka added a commit that referenced this pull request Nov 8, 2024

use has_free_unbacked_symbols

c79c201

ghstack-source-id: b3ec8be Pull Request resolved: #140027

pytorch-bot bot added the module: dynamo label Nov 8, 2024

laithsakka changed the title ~~use has_free_unbacked_symbols instead of bool(free_unbacked_symbols)~~ Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) Nov 8, 2024

laithsakka requested a review from anijain2305 November 8, 2024 01:28

ezyang approved these changes Nov 8, 2024

View reviewed changes

laithsakka added a commit that referenced this pull request Nov 8, 2024

use has_free_unbacked_symbols

04fe99b

ghstack-source-id: 709556b Pull Request resolved: #140027

isuruf reviewed Nov 8, 2024

View reviewed changes

torch/fx/experimental/symbolic_shapes.py Outdated Show resolved Hide resolved

laithsakka added a commit that referenced this pull request Nov 8, 2024

use has_free_unbacked_symbols

0505c83

ghstack-source-id: 1958a08 Pull Request resolved: #140027

laithsakka added a commit that referenced this pull request Nov 12, 2024

use has_free_unbacked_symbols

e077773

ghstack-source-id: 716347f Pull Request resolved: #140027

isuruf reviewed Nov 13, 2024

View reviewed changes

torch/fx/experimental/symbolic_shapes.py Outdated Show resolved Hide resolved

laithsakka added a commit that referenced this pull request Nov 14, 2024

use has_free_unbacked_symbols

b21e004

ghstack-source-id: 4a72407 Pull Request resolved: #140027

laithsakka added a commit that referenced this pull request Nov 15, 2024

use has_free_unbacked_symbols

a02dcc3

ghstack-source-id: 91754f6 Pull Request resolved: #140027

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2024

pytorchmergebot added the merging label Nov 15, 2024

pytorchmergebot added the Merged label Nov 15, 2024

pytorchmergebot closed this in 500ce29 Nov 15, 2024

pytorchmergebot removed the merging label Nov 15, 2024

github-actions bot deleted the gh/laithsakka/98/head branch December 19, 2024 02:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

Uh oh!

laithsakka commented Nov 7, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Nov 7, 2024 •

edited

Loading

Uh oh!

laithsakka commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

laithsakka commented Nov 15, 2024

Uh oh!

pytorchmergebot commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

Use has_free_unbacked_symbols instead of bool(free_unbacked_symbols) #140027

Uh oh!

Conversation

laithsakka commented Nov 7, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140027

❗ 1 Active SEVs

✅ No Failures

Uh oh!

laithsakka commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

laithsakka commented Nov 15, 2024

Uh oh!

pytorchmergebot commented Nov 15, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

laithsakka commented Nov 7, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Nov 7, 2024 •

edited

Loading