KEMBAR78
Updated docstrings referring to `torch.expand` to point to `torch.Tensor.expand` by twaclaw · Pull Request #140045 · pytorch/pytorch · GitHub
Skip to content

Conversation

@twaclaw
Copy link
Contributor

@twaclaw twaclaw commented Nov 7, 2024

torch.expand was moved to torch.Tensor.expand but some docstrings still refer to torch.expand

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140045

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 9a30f68 with merge base eabef50 (image):

NEW FAILURE - The following job has failed:

  • linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test (gh)
    RuntimeError: cuDNN version incompatibility: PyTorch was compiled against (9, 5, 1) but found runtime version (9, 1, 0). PyTorch already comes bundled with cuDNN. One option to resolving this error is to ensure PyTorch can find the bundled cuDNN. one possibility is that there is a conflicting cuDNN in LD_LIBRARY_PATH.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@bdhirsh bdhirsh added the release notes: python_frontend python frontend release notes category label Nov 8, 2024
@bdhirsh
Copy link
Contributor

bdhirsh commented Nov 8, 2024

@twaclaw you need to sign the CLA

Comment on lines 13830 to +13832
torch.expand_copy,
r"""
Performs the same operation as :func:`torch.expand`, but all output tensors
Performs the same operation as :func:`torch.Tensor.expand`, but all output tensors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this? I don't see torch.expand_copy in the generated docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would need to be added to https://github.com/pytorch/pytorch/blob/main/docs/source/tensors.rst?plain=1#L433 to show up

That said, seems like none of the {*}_copy functions (other than index_copy and narrow_copy) show up in documentation so it's probably ok not to add expand_copy there in this PR

@svekars do you know why all these {*}_copy variants are not in the generated docs and why they are not in the coverage skiplist?

@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 8, 2024
@mikaylagawarecki mikaylagawarecki added the topic: docs topic category label Nov 21, 2024
@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…sor.expand` (pytorch#140045)

`torch.expand` was moved to `torch.Tensor.expand` but some docstrings still refer to `torch.expand`

Pull Request resolved: pytorch#140045
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants