KEMBAR78

Only compute new_untracked_symbols and new_unbacked_bindings if needed. by laithsakka · Pull Request #140083 · pytorch/pytorch · GitHub

Only compute new_untracked_symbols and new_unbacked_bindings if needed. #140083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

laithsakka wants to merge 1 commit into pytorch:main from laithsakka:export-D65638637

Contributor

laithsakka commented Nov 8, 2024 •

edited by pytorch-bot bot

Loading

Summary:
237s -> 198..
buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

Test Plan: NA

Differential Revision: D65638637

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames

pytorch-bot bot commented Nov 8, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140083

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[DomainsOnly] Jobs fail with GLIBC version not found

✅ No Failures

As of commit 9058449 with merge base d276688 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: fx label

facebook-github-bot added the fx label

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

facebook-github-bot added the fb-exported label

laithsakka requested review from aorenste, bobrenjc93, ezyang and isuruf

November 8, 2024 01:26

laithsakka changed the title ~~only compute new_untracked_symbols() and new_unbacked_bindings() if needed.~~ Only compute new_untracked_symbols() and new_unbacked_bindings() if needed.

pytorch-bot bot added the ciflow/trunk label

laithsakka changed the title ~~Only compute new_untracked_symbols() and new_unbacked_bindings() if needed.~~ Only compute new_untracked_symbols and new_unbacked_bindings if needed.

laithsakka requested a review from anijain2305

November 8, 2024 01:28

ezyang approved these changes

View reviewed changes

laithsakka force-pushed the export-D65638637 branch from e0b1293 to 5d53f6a Compare

November 8, 2024 03:41

laithsakka added a commit to laithsakka/pytorch that referenced this pull request


          only compute new_untracked_symbols() and new_unbacked_bindings() if n…

0d41de6

…eeded. (pytorch#140083)

Summary:

237s -> 170s. 
buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

Test Plan: NA

Differential Revision: D65638637

laithsakka force-pushed the export-D65638637 branch from 5d53f6a to 0d41de6 Compare

November 8, 2024 03:41

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

1 similar comment

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

isuruf reviewed

View reviewed changes

torch/fx/passes/runtime_assert.py Outdated Show resolved Hide resolved

isuruf approved these changes

View reviewed changes

laithsakka force-pushed the export-D65638637 branch from 0d41de6 to 46db9a0 Compare

November 18, 2024 23:34

pytorch-bot bot added ciflow/inductor module: dynamo labels

Contributor Author

laithsakka commented Nov 18, 2024

mad it even better.

Contributor

facebook-github-bot commented Nov 18, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

isuruf reviewed

View reviewed changes

torch/fx/passes/runtime_assert.py Outdated Show resolved Hide resolved

laithsakka force-pushed the export-D65638637 branch from 59f44f7 to 99a3aa2 Compare

November 19, 2024 00:59

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

laithsakka force-pushed the export-D65638637 branch from 99a3aa2 to 1e05f93 Compare

November 19, 2024 05:28

laithsakka force-pushed the export-D65638637 branch from 1e05f93 to 9c7fdb8 Compare

November 19, 2024 05:28

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

1 similar comment

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

laithsakka force-pushed the export-D65638637 branch from 9c7fdb8 to a1e215d Compare

November 19, 2024 07:13

laithsakka added a commit to laithsakka/pytorch that referenced this pull request


          only compute new_untracked_symbols() and new_unbacked_bindings() if n…

9523ffd

…eeded. (pytorch#140083)

Summary:

237s -> 198.. 
buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

Test Plan: NA

Reviewed By: ezyang

Differential Revision: D65638637

laithsakka force-pushed the export-D65638637 branch from a1e215d to 9523ffd Compare

November 19, 2024 07:13

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

1 similar comment

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637


          only compute new_untracked_symbols() and new_unbacked_bindings() if n…

…eeded. (pytorch#140083)

Summary:

237s -> 198.. 
buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

Test Plan: NA

Reviewed By: ezyang

Differential Revision: D65638637

laithsakka force-pushed the export-D65638637 branch from 9523ffd to 9058449 Compare

November 19, 2024 18:02

Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65638637

Contributor Author

laithsakka commented Nov 19, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Nov 19, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

anijain2305 approved these changes

View reviewed changes

Collaborator

pytorchmergebot commented Nov 20, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

Contributor Author

laithsakka commented Nov 20, 2024

@pytorchbot merge

Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

caa3a3e

pytorchmergebot added Merged and removed merging labels

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          Only compute new_untracked_symbols and new_unbacked_bindings if neede…

6a19ea4

…d. (pytorch#140083)

Summary:
237s -> 198..
buck2 run fbcode//mode/opt fbcode//torchrec/distributed/tests:pt2_compile_benchmark -- --num-features=2000

Test Plan: NA

Differential Revision: D65638637

Pull Request resolved: pytorch#140083
Approved by: https://github.com/ezyang, https://github.com/isuruf, https://github.com/anijain2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported fx Merged module: dynamo release notes: fx