KEMBAR78
Fix type description of torch.chunk by zeshengzong · Pull Request #140089 · pytorch/pytorch · GitHub
Skip to content

Fix type description of torch.chunk #140089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix type description of torch.chunk #140089

wants to merge 1 commit into from

Conversation

@zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Nov 8, 2024 •
edited
Loading

Fixes #126278

  • Change return type description of torch.chunk to tuple
  • Add type for input parameters

Before
image

After
image

cc @drisspg @janeyx99

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140089

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e69815e with merge base f0ffaa5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Nov 8, 2024
@zeshengzong zeshengzong marked this pull request as ready for review November 8, 2024 02:28
@zeshengzong
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@zeshengzong
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@zeshengzong zeshengzong deleted the opt/docs/4 branch November 8, 2024 15:30
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@zeshengzong
Fix type description of torch.chunk (pytorch#140089)
3c1f338 
Fixes pytorch#126278

- Change return type description of `torch.chunk` to tuple
- Add type for input parameters

**Before**
![image](https://github.com/user-attachments/assets/087b6cfa-0815-443b-a69a-785ca4b421d7)

**After**
![image](https://github.com/user-attachments/assets/19532553-6004-4246-a6cf-f7f685f5775c)

Pull Request resolved: pytorch#140089
Approved by: https://github.com/awgu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu awgu approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.chunk returns Tuple, not List

4 participants

@zeshengzong @pytorchmergebot @awgu @pytorchbot