correctly keep track of processed tensors for foreach reductions #140103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140103
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cbbb78f with merge base 43f0fe6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
approved these changes
Nov 8, 2024
janeyx99
added
ciflow/trunk
ngimel
commented
Nov 8, 2024
There was a problem hiding this comment.
I'm not sure inputs here are large enough to trigger the bug. We need to test 2 cases
- Enough chunks across all the tensors to trigger multiple kernel launches. That requires tensors totalling
>65536 * 320elements today, given that we launch at most 320 blocks - Enough tensors to trigger multiple kernel launches, don't know off the top of my head but should be at least 50-100
By looking at it, foreach inputs would generate at most 10 small-ish tensors, so might not trigger either case.
We might be better off just writing one off tests for this, wdyt?
There was a problem hiding this comment.
Yea, that'd probably be easiest, the meta tests also just failed too so that makes the decision easier
There was a problem hiding this comment.
Eventually we probably want both tests
janeyx99
force-pushed
the
ngimel/foreach_norm
branch
from
544a37d to
dacd07b
Compare
janeyx99
reviewed
Nov 8, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
zero000064
pushed a commit
to zero000064/pytorch
that referenced
this pull request
Nov 14, 2024
…orch#140103) Fixes pytorch#140066 Pull Request resolved: pytorch#140103 Approved by: https://github.com/janeyx99 Co-authored-by: Jane Xu <janeyx@meta.com>
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
…orch#140103) Fixes pytorch#140066 Pull Request resolved: pytorch#140103 Approved by: https://github.com/janeyx99 Co-authored-by: Jane Xu <janeyx@meta.com>
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…orch#140103) Fixes pytorch#140066 Pull Request resolved: pytorch#140103 Approved by: https://github.com/janeyx99 Co-authored-by: Jane Xu <janeyx@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140066