Give the magma build job id-token write permissions #140141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure-aws-credentials action requires special permissions: https://github.com/aws-actions/configure-aws-credentials?tab=readme-ov-file#oidc Give "id-token: write" permssion to the job that sets the AWS credentials to upload to the S3 bucket. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140141
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 012ab6a with merge base c1c94cb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot merge -f "lint is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
The configure-aws-credentials action requires special permissions: https://github.com/aws-actions/configure-aws-credentials?tab=readme-ov-file#oidc Give "id-token: write" permssion to the job that sets the AWS credentials to upload to the S3 bucket. Fixes pytorch#139397 Pull Request resolved: pytorch#140141 Approved by: https://github.com/atalman
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
The configure-aws-credentials action requires special permissions: https://github.com/aws-actions/configure-aws-credentials?tab=readme-ov-file#oidc Give "id-token: write" permssion to the job that sets the AWS credentials to upload to the S3 bucket. Fixes pytorch#139397 Pull Request resolved: pytorch#140141 Approved by: https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure-aws-credentials action requires special permissions: https://github.com/aws-actions/configure-aws-credentials?tab=readme-ov-file#oidc
Give "id-token: write" permssion to the job that sets the AWS credentials to upload to the S3 bucket.
Fixes #139397